tweak(mumble): swap to completely using TCP ping for checking if UDP is available #3052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
invalid
…is available - The previous implementation would constantly swap between UDP/TCP constantly causing the players mic to stutter - The old implementation should've been completely removed, this is an oversight in citizenfx@f182bb5
AvarianKnight
force-pushed
the
tweak/mumble-fixes-2
branch
from
08a5077 to
12ffa24
Compare
FabianTerhorst
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Fix broken implementation of f182bb5, time since last UDP received doesn't matter as this is all determined by MumbleCrypto.
How is this PR achieving the goal
Removes UDP timeout checks and once
m_hasUdpis set to true, disallow it from being set to false again for the first 20 seconds of a connection (mimicking mumbles implementation https://github.com/mumble-voip/mumble/blob/e64f334c9376cfc8425916a152e3c09e301d5188/src/mumble/ServerHandler.cpp#L648-L663)This PR applies to the following area(s)
FiveM, RedM
Successfully tested on
Game builds: ..
Platforms:
Checklist
These changes were not tested, but did compile fine.
Fixes issues
Fixes AvarianKnight/pma-voice#510