Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extra-natives-five): Fix unable to set last pixel of runtime texture #2991

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

Lucas7yoshi
Copy link
Contributor

@Lucas7yoshi Lucas7yoshi commented Dec 8, 2024

Goal of this PR

Fix not being able to set the last/bottom right pixel of runtime textures.

How is this PR achieving the goal

Fixing a logic error (>= when it should be >)

This PR applies to the following area(s)

FiveM, Natives

Successfully tested on

Game builds: 3258

Platforms: Windows

Note: tested and was unable to set outside bounds of a 8x4 texture through either x/y.
Would be very surprised if this broke based on build.

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

N/A

@github-actions github-actions bot added the triage Needs a preliminary assessment to determine the urgency and required action label Dec 8, 2024
Copy link
Contributor

@dalekenium-cfx dalekenium-cfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough. Looks good to me.

@dalekenium-cfx dalekenium-cfx added ready-to-merge This PR is enqueued for merging and removed triage Needs a preliminary assessment to determine the urgency and required action labels Dec 9, 2024
@prikolium-cfx prikolium-cfx merged commit bb24a64 into citizenfx:master Dec 25, 2024
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR is enqueued for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants