Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak(game/fivem/loadscreen): Initialize the player for RAGE with manual shutdown #2960

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

TheGamerzs
Copy link
Contributor

Goal of this PR

Sets the Players Ped to 0,0,0; this makes RAGE render/activate game mechanics (Map, Entities, Entity dependent natives, UI).
Also, it removes setting the doSetup condition, as this code is unrelated and not reachable via manual shutdown.

How is this PR achieving the goal

Sets the Players Ped to 0,0,0
Remove loadsThread.doSetup = true;, in ShutdownLoadingScreenNui

This PR applies to the following area(s)

FiveM

Successfully tested on

Game builds: 1, 2060, 3258

Platforms: Windows Client

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Additional Information

Current (Only distant cars, water, weather, and time are present & entities are static if spawned):
Screenshot 2024-11-25 002808

New (Playable game state):
Screenshot 2024-11-25 012400

Most people don't see this behaviour, as spawn managers/menus set the coords.

@TheGamerzs TheGamerzs changed the title tweak(native/fivem/ShutdownLoadingScreenNui): Initialize the player for RAGE functionality tweak(game/fivem/loadscreen): Initialize the player for RAGE with manual shutdown Nov 25, 2024
@github-actions github-actions bot added the triage Needs a preliminary assessment to determine the urgency and required action label Nov 25, 2024
Copy link
Contributor

@dalekenium-cfx dalekenium-cfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major complaints. I approve.

@dalekenium-cfx dalekenium-cfx added ready-to-merge This PR is enqueued for merging and removed triage Needs a preliminary assessment to determine the urgency and required action labels Dec 5, 2024
@TheGamerzs
Copy link
Contributor Author

The only reason he's standing is the interior or whatever is at 0,0,0 on build 2060 and later.
On builds 1 and 1604 he's falling.

Should the docs be updated to reflect this change?
I didn't freeze him, as this would've broken backwards compatibility.

@prikolium-cfx prikolium-cfx merged commit 3926dcf into citizenfx:master Dec 26, 2024
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR is enqueued for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants