Merge pull request #6 from cite-architecture/dev

Correct type inheritance

Project.toml

@@ -1,7 +1,7 @@
 name = "CitableBase"
 uuid = "d6f014bd-995c-41bd-9893-703339864534"
 authors = ["Neel Smith <[email protected]>"]
-version = "1.2.1"
+version = "1.2.2"
 
 [deps]
 DocStringExtensions = "ffbed154-4ef7-542d-bbb7-c09d3a79fcae"

src/versions.jl

@@ -1,7 +1,7 @@
 """Catch-all function for `dropversion` method.
 $(SIGNATURES)
 """
-function dropversion(u::Urn)
+function dropversion(u::T) where {T <: Urn}
     msg = string("dropversion not implemented for ", typeof(u))
     @warn(msg)
     nothing
@@ -10,7 +10,7 @@ end
 """Catch-all function for `addversion` method.
 $(SIGNATURES)
 """
-function addversion(u::Urn, s::AbstractString)
+function addversion(u::T, s::AbstractString) where {T <: Urn}
     msg = string("addversion not implemented for ", typeof(u))
     @warn(msg)
     nothing

test/test_functiondefs.jl

@@ -19,4 +19,21 @@ end
     u = FakeUrn("urn:fake:id.subid")
     @test isnothing(dropversion(u))
     @test isnothing(addversion(u, "versionid"))
+end
+
+
+
+@testset "Test ovveride validurn" begin
+    struct FakeUrn <: Urn
+        urn::AbstractString
+    end
+    function dropversion(u::FakeUrn)
+        "Success"
+    end
+    function addversion(u::FakeUrn, s)
+        "Success adding $s"
+    end
+    u = FakeUrn("urn:fake:id.subid")
+    @test dropversion(u) == "Success"
+    @test addversion(u, "versionid") == "Success adding versionid"
 end