Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PE Vulnerability Pull #2507

Merged
merged 19 commits into from
Feb 23, 2024
Merged

PE Vulnerability Pull #2507

merged 19 commits into from
Feb 23, 2024

Conversation

edujosemena
Copy link
Contributor

@edujosemena edujosemena commented Feb 6, 2024

🗣 Description

closes #2417 and adds the ability to connect to the Posture and exposure API to be able to pull in vulnerability data from the various sources collected

💭 Motivation and context

Adding the ability to get data from posture and expose database

🧪 Testing

Test the database and ensure that the data was added properly in the following tables.
Domains (new domains found)
Services (Every vulnerability must have a service related to it)
Vulnerabilities

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

@DJensen94 DJensen94 marked this pull request as ready for review February 23, 2024 19:00
Copy link
Contributor

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit out of the scan functionality, but from a code perspective this LGTM.

Copy link
Contributor

@Matthew-Grayson Matthew-Grayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great

Copy link
Collaborator

@rapidray12 rapidray12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are going to have to up our logging game.

console.log("test") is a bit useless

Once in the LZ environment the only way we will know what is happening in the app is via the logs

@Matthew-Grayson Matthew-Grayson merged commit 7518049 into master Feb 23, 2024
15 checks passed
@Matthew-Grayson Matthew-Grayson deleted the EM-pe-vuln-pull branch February 23, 2024 23:48
@DJensen94 DJensen94 restored the EM-pe-vuln-pull branch February 26, 2024 18:21
This was referenced Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Universal API Push/Pull to PE Environment
6 participants