Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1857 fix censys.ts #2416

Merged
merged 4 commits into from
Dec 19, 2023
Merged

1857 fix censys.ts #2416

merged 4 commits into from
Dec 19, 2023

Conversation

Matthew-Grayson
Copy link
Contributor

@Matthew-Grayson Matthew-Grayson commented Dec 15, 2023

Refactor censys.ts to use v2 of certificates API. This scan enumerates subdomains for an organization.
Add deduping for domain names to reduce number of dns queries by 95% in testing.

🗣 Description

💭 Motivation and context

See issue #1857

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@Matthew-Grayson Matthew-Grayson self-assigned this Dec 15, 2023
@Matthew-Grayson Matthew-Grayson linked an issue Dec 15, 2023 that may be closed by this pull request
@Matthew-Grayson Matthew-Grayson added the Backend ASM-VDB Technical Infrastructure and Database label Dec 15, 2023
@Matthew-Grayson Matthew-Grayson marked this pull request as ready for review December 18, 2023 19:38
@Matthew-Grayson Matthew-Grayson changed the title 1857 fix censys scans 1857 fix censys.ts Dec 18, 2023
@cduhn17 cduhn17 self-requested a review December 19, 2023 17:22
Copy link
Contributor

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - internal code review also complete

@cduhn17 cduhn17 merged commit 292aaf2 into master Dec 19, 2023
11 of 14 checks passed
@cduhn17 cduhn17 deleted the 1857-fix-censys-scans branch December 19, 2023 17:22
@Matthew-Grayson Matthew-Grayson linked an issue Dec 20, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend ASM-VDB Technical Infrastructure and Database
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Censys to return all results Fix Censys Scans
3 participants