Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add email_bucket_name to env.yml #2415

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Add email_bucket_name to env.yml #2415

merged 1 commit into from
Dec 14, 2023

Conversation

JCantu248
Copy link
Contributor

🗣 Description

Add email_bucket_name to list of environment variables.

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@JCantu248 JCantu248 added the Backend ASM-VDB Technical Infrastructure and Database label Dec 14, 2023
@JCantu248 JCantu248 self-assigned this Dec 14, 2023
nickviola
nickviola approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ameliav
ameliav approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@ameliav ameliav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! I see it's a straightforward change.

schmelz21
schmelz21 approved these changes Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@schmelz21 schmelz21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough... please merge.

@JCantu248 JCantu248 merged commit caf785a into master Dec 14, 2023
12 of 14 checks passed
@JCantu248 JCantu248 deleted the issue-2406/add_email_template_asset_s3_logic branch December 14, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickviola nickviola nickviola approved these changes

@ameliav ameliav ameliav approved these changes

@schmelz21 schmelz21 schmelz21 approved these changes

Assignees

@JCantu248 JCantu248

Labels
Backend ASM-VDB Technical Infrastructure and Database
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JCantu248 @nickviola @ameliav @schmelz21