Skip to content
This repository has been archived by the owner on Aug 9, 2023. It is now read-only.

⚠️ CONFLICT! Lineage pull request for: skeleton #16

Draft
wants to merge 71 commits into
base: develop
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
71 commits
Select commit Hold shift + click to select a range
57b4abe
Update actions/setup-go from v2 to v3
mcdonnnj May 27, 2022
8f68498
Update the version of Go used from 1.16 to 1.18
mcdonnnj May 27, 2022
fc55e84
Update the version of Go used from 1.18 to 1.19
mcdonnnj Nov 8, 2022
ec83308
Merge pull request #113 from cisagov/improvement/update_go_configuration
mcdonnnj Nov 8, 2022
2775dfa
Bump hashicorp/setup-terraform from 1 to 2
dependabot[bot] Nov 8, 2022
4925eb1
Merge pull request #111 from cisagov/dependabot/github_actions/hashic…
mcdonnnj Nov 8, 2022
1f7c62e
Bump actions/setup-python from 3 to 4
dependabot[bot] Nov 8, 2022
f74b4a3
Merge pull request #115 from cisagov/dependabot/github_actions/action…
mcdonnnj Nov 8, 2022
6a9c630
Add an ownership comment to the Dependabot configuration
mcdonnnj May 27, 2022
dfd54e9
Add additional Dependabot ignore directives
mcdonnnj May 27, 2022
a8bcddd
Merge pull request #112 from cisagov/improvement/update_dependabot_ig…
mcdonnnj Nov 8, 2022
71a88a5
Remove usage of set-output from our GitHub Actions workflow
mcdonnnj Oct 11, 2022
0867685
Merge pull request #119 from cisagov/bug/update_github_actions_workflow
mcdonnnj Nov 8, 2022
21a68f4
Enable the allow-non-breakable-inline-mappings rule for yamllint
mcdonnnj Sep 7, 2022
3547c4f
Increase the maximum line length in the yamllint configuration
mcdonnnj Sep 7, 2022
cfa9ba5
Merge pull request #117 from cisagov/improvement/update_yamllint_line…
mcdonnnj Nov 8, 2022
b1ea3d4
Fix the repo of the flake8 pre-commit hook
mcdonnnj Oct 14, 2022
2a98c6a
Merge pull request #120 from cisagov/bug/verify_pre-commit_hook_repos
mcdonnnj Nov 8, 2022
fb8d13f
Update pre-commit hooks
mcdonnnj May 27, 2022
bb9c2a0
Merge pull request #114 from cisagov/maintenance/update_pre-commit_hooks
mcdonnnj Nov 8, 2022
e5fbd70
Add a label configuration file
mcdonnnj Oct 5, 2022
b9792a8
Add a workflow to synchronize repository labels
mcdonnnj Oct 5, 2022
161c4ae
Remove duplicate label
jsf9k Oct 21, 2022
5993231
Add a label for issues or PRs that involve test code
jsf9k Oct 21, 2022
c4fbf20
Merge pull request #118 from cisagov/improvement/add_label_sync_workflow
mcdonnnj Nov 8, 2022
6cc53dc
Fix GitHub label color values
mcdonnnj Nov 9, 2022
8f12635
Correct spacing in yamllint rules
mcdonnnj Nov 9, 2022
e803e1a
Merge pull request #122 from cisagov/bug/fix_bad_configurations
mcdonnnj Nov 9, 2022
592cedd
Merge https://github.com/cisagov/skeleton-generic into lineage/skeleton
Nov 14, 2022
0bb91c5
Update pre-commit hooks
mcdonnnj Jan 31, 2023
0eda781
Merge pull request #124 from cisagov/maintenance/update_pre-commit_hooks
jmorrowomni Feb 2, 2023
36094d8
Merge https://github.com/cisagov/skeleton-generic into lineage/skeleton
Feb 2, 2023
313e792
Add a security label
jsf9k Feb 2, 2023
b7c0a75
Merge pull request #125 from cisagov/improvement/add-security-label
jmorrowomni Feb 2, 2023
4f2feeb
Merge https://github.com/cisagov/skeleton-generic into lineage/skeleton
Feb 2, 2023
744f07e
Add @jasonodoom as a default codeowner
jsf9k Mar 24, 2023
3eed760
Merge pull request #128 from cisagov/add-odoom-to-default-codeowners
jasonodoom Mar 26, 2023
da486a8
Merge https://github.com/cisagov/skeleton-generic into lineage/skeleton
Mar 26, 2023
8d39c8b
Use Python 3.11 for the `lint` job in the `build` workflow
mcdonnnj Apr 19, 2023
5f4b768
Merge pull request #130 from cisagov/improvement/update_python_versio…
jmorrowomni Apr 20, 2023
db5e7ff
Update pre-commit hook versions
mcdonnnj Mar 27, 2023
c9028cf
Merge pull request #129 from cisagov/maintenance/update_pre-commit_hooks
jmorrowomni Apr 20, 2023
4c595e6
Bump actions/setup-go from 3 to 4
dependabot[bot] Mar 27, 2023
847cd13
Merge pull request #127 from cisagov/dependabot/github_actions/action…
jmorrowomni Apr 20, 2023
9984792
Install/upgrade setuptools and wheel when upgrading pip
jsf9k Feb 24, 2023
7250368
Merge pull request #126 from cisagov/improvement/install-setuptools-a…
jmorrowomni Apr 20, 2023
01e1aa7
Merge https://github.com/cisagov/skeleton-generic into lineage/skeleton
Apr 20, 2023
a0bc20b
Add Go hooks to support go code for our projects
jasonodoom May 5, 2023
3628e5f
Add Staticcheck
jasonodoom May 5, 2023
668724f
Fix indentation
jasonodoom May 5, 2023
3d422b8
Fix indentation
jasonodoom May 5, 2023
5571f47
Fix indentation
jasonodoom May 5, 2023
4fd9501
Fix formatting
jasonodoom May 5, 2023
412101a
Fix formatting
jasonodoom May 5, 2023
a346fb5
Fix formatting
jasonodoom May 5, 2023
c47038b
Revert updated versions for existing hooks
jasonodoom May 5, 2023
eb52678
Fix formatting
jasonodoom May 5, 2023
f8179f1
Remove extra hook ids
jasonodoom May 5, 2023
42820e2
Replace hooks with repo based option when available
jasonodoom May 8, 2023
7f372e6
Remove the go-lint hook from the pre-commit configuration
mcdonnnj Jun 7, 2023
b823111
Update pre-commit hook versions
mcdonnnj May 31, 2023
b770fc6
Add apostrophe to Qapla
jasonodoom May 31, 2023
24a0008
detecting virtualenv installation successfully
arcsector May 17, 2023
f01965a
Whitespace change to make shfmt linter happy
jsf9k May 19, 2023
43d588f
Fix two broken links
jsf9k Apr 25, 2023
e098255
Disable caching for the setup-go Action
mcdonnnj May 31, 2023
edf1338
Bump Go from 1.19 to 1.20
mcdonnnj May 31, 2023
c2ebb74
Merge https://github.com/cisagov/skeleton-generic into lineage/skeleton
Jun 7, 2023
42f481c
Merge branch 'develop' into add-go-hooks
jmorrowomni Jun 8, 2023
bd762fe
Merge pull request #133 from cisagov/add-go-hooks
mcdonnnj Jun 8, 2023
5ffaa91
Merge https://github.com/cisagov/skeleton-generic into lineage/skeleton
Jun 8, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .ansible-lint
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
---
# See https://ansible-lint.readthedocs.io/en/latest/configuring.html
# for a list of the configuration elements that can exist in this
# file.
# See https://ansible-lint.readthedocs.io/configuring/ for a list of
# the configuration elements that can exist in this file.
enable_list:
# Useful checks that one must opt-into. See here for more details:
# https://ansible-lint.readthedocs.io/en/latest/rules.html
# https://ansible-lint.readthedocs.io/rules/
- fcqn-builtins
- no-log-password
- no-same-owner
Expand Down
4 changes: 2 additions & 2 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
# These owners will be the default owners for everything in the
# repo. Unless a later match takes precedence, these owners will be
# requested for review when someone opens a pull request.
* @dav3r @felddy @jsf9k @mcdonnnj
* @dav3r @felddy @jasonodoom @jsf9k @mcdonnnj

# These folks own any files in the .github directory at the root of
# the repository and any of its subdirectories.
/.github/ @dav3r @felddy @jsf9k @mcdonnnj
/.github/ @dav3r @felddy @jasonodoom @jsf9k @mcdonnnj
11 changes: 11 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ updates:
directory: "/"
schedule:
interval: "weekly"
<<<<<<< HEAD
ignore:
- dependency-name: actions/cache
- dependency-name: actions/checkout
Expand All @@ -28,6 +29,16 @@ updates:
# - dependency-name: docker/login-action
# - dependency-name: docker/setup-buildx-action
# - dependency-name: docker/setup-qemu-action
=======
# ignore:
# # Managed by cisagov/skeleton-generic
# - dependency-name: actions/cache
# - dependency-name: actions/checkout
# - dependency-name: actions/setup-go
# - dependency-name: actions/setup-python
# - dependency-name: hashicorp/setup-terraform
# - dependency-name: mxschmitt/action-tmate
>>>>>>> e803e1ac48ea53dc766d05935fbc38d2f4ad385e

- package-ecosystem: "pip"
directory: "/"
Expand Down
70 changes: 70 additions & 0 deletions .github/labels.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
---
# Rather than breaking up descriptions into multiline strings we disable that
# specific rule in yamllint for this file.
# yamllint disable rule:line-length
- color: "eb6420"
description: This issue or pull request is awaiting the outcome of another issue or pull request
name: blocked
- color: "000000"
description: This issue or pull request involves changes to existing functionality
name: breaking change
- color: "d73a4a"
description: This issue or pull request addresses broken functionality
name: bug
- color: "07648d"
description: This issue will be advertised on code.gov's Open Tasks page (https://code.gov/open-tasks)
name: code.gov
- color: "0366d6"
description: Pull requests that update a dependency file
name: dependencies
- color: "5319e7"
description: This issue or pull request improves or adds to documentation
name: documentation
- color: "cfd3d7"
description: This issue or pull request already exists or is covered in another issue or pull request
name: duplicate
- color: "b005bc"
description: A high-level objective issue encompassing multiple issues instead of a specific unit of work
name: epic
- color: "000000"
description: Pull requests that update GitHub Actions code
name: github-actions
- color: "0e8a16"
description: This issue or pull request is well-defined and good for newcomers
name: good first issue
- color: "ff7518"
description: Pull request that should count toward Hacktoberfest participation
name: hacktoberfest-accepted
- color: "a2eeef"
description: This issue or pull request will add or improve functionality, maintainability, or ease of use
name: improvement
- color: "fef2c0"
description: This issue or pull request is not applicable, incorrect, or obsolete
name: invalid
- color: "ce099a"
description: This pull request is ready to merge during the next Lineage Kraken release
name: kraken 🐙
- color: "a4fc5d"
description: This issue or pull request requires further information
name: need info
- color: "fcdb45"
description: This pull request is awaiting an action or decision to move forward
name: on hold
- color: "ef476c"
description: This issue is a request for information or needs discussion
name: question
- color: "d73a4a"
description: This issue or pull request addresses a security issue
name: security
- color: "00008b"
description: This issue or pull request adds or otherwise modifies test code
name: test
- color: "1d76db"
description: This issue or pull request pulls in upstream updates
name: upstream update
- color: "d4c5f9"
description: This issue or pull request increments the version number
name: version bump
- color: "ffffff"
description: This issue will not be incorporated
name: wontfix
29 changes: 18 additions & 11 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,28 +45,35 @@ jobs:
uses: cisagov/setup-env-github-action@develop
- uses: actions/checkout@v3
- id: setup-python
uses: actions/setup-python@v3
uses: actions/setup-python@v4
with:
python-version: "3.10"
python-version: "3.11"
# We need the Go version and Go cache location for the actions/cache step,
# so the Go installation must happen before that.
<<<<<<< HEAD
- uses: actions/setup-go@v3
=======
- id: setup-go
<<<<<<< HEAD
uses: actions/setup-go@v3
>>>>>>> e803e1ac48ea53dc766d05935fbc38d2f4ad385e
=======
uses: actions/setup-go@v4
>>>>>>> 72503682a20fa77b887910ac6ec8556c77ce7d5e
with:
go-version: "1.16"
- name: Store installed Go version
id: go-version
run: |
echo "::set-output name=version::"\
"$(go version | sed 's/^go version go\([0-9.]\+\) .*/\1/')"
# There is no expectation for actual Go code so we disable caching as
# it relies on the existence of a go.sum file.
cache: false
go-version: "1.20"
- name: Lookup Go cache directory
id: go-cache
run: |
echo "::set-output name=dir::$(go env GOCACHE)"
echo "dir=$(go env GOCACHE)" >> $GITHUB_OUTPUT
- uses: actions/cache@v3
env:
BASE_CACHE_KEY: "${{ github.job }}-${{ runner.os }}-\
py${{ steps.setup-python.outputs.python-version }}-\
go${{ steps.go-version.outputs.version }}-\
go${{ steps.setup-go.outputs.go-version }}-\
packer${{ steps.setup-env.outputs.packer-version }}-\
tf${{ steps.setup-env.outputs.terraform-version }}-"
with:
Expand Down Expand Up @@ -117,7 +124,7 @@ jobs:
run: go install ${PACKAGE_URL}@${PACKAGE_VERSION}
- name: Install dependencies
run: |
python -m pip install --upgrade pip
python -m pip install --upgrade pip setuptools wheel
pip install --upgrade --requirement requirements-test.txt
- name: Set up pre-commit hook environments
run: pre-commit install-hooks
Expand Down
29 changes: 29 additions & 0 deletions .github/workflows/sync-labels.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
---
name: sync-labels

on:
push:
paths:
- '.github/labels.yml'
- '.github/workflows/sync-labels.yml'

permissions:
contents: read

jobs:
labeler:
permissions:
# actions/checkout needs this to fetch code
contents: read
# crazy-max/ghaction-github-labeler needs this to manage repository labels
issues: write
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Sync repository labels
if: success()
uses: crazy-max/ghaction-github-labeler@v4
with:
# This is a hideous ternary equivalent so we only do a dry run unless
# this workflow is triggered by the develop branch.
dry-run: ${{ github.ref_name == 'develop' && 'false' || 'true' }}
51 changes: 35 additions & 16 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ default_language_version:

repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.1.0
rev: v4.4.0
hooks:
- id: check-case-conflict
- id: check-executables-have-shebangs
Expand All @@ -32,35 +32,54 @@ repos:

# Text file hooks
- repo: https://github.com/igorshubovych/markdownlint-cli
rev: v0.31.1
rev: v0.34.0
hooks:
- id: markdownlint
args:
- --config=.mdl_config.yaml
- repo: https://github.com/pre-commit/mirrors-prettier
rev: v2.6.1
rev: v3.0.0-alpha.9-for-vscode
hooks:
- id: prettier
- repo: https://github.com/adrienverge/yamllint
rev: v1.26.3
rev: v1.32.0
hooks:
- id: yamllint
args:
- --strict

# GitHub Actions hooks
- repo: https://github.com/python-jsonschema/check-jsonschema
rev: 0.14.2
rev: 0.23.1
hooks:
- id: check-github-actions
- id: check-github-workflows

# pre-commit hooks
- repo: https://github.com/pre-commit/pre-commit
rev: v2.17.0
rev: v3.3.2
hooks:
- id: validate_manifest

# Go hooks
- repo: https://github.com/TekWizely/pre-commit-golang
rev: v1.0.0-rc.1
hooks:
# Style Checkers
- id: go-critic
# StaticCheck
- id: go-staticcheck-repo-mod
# Go Build
- id: go-build-repo-mod
# Go Mod Tidy
- id: go-mod-tidy-repo
# Go Test
- id: go-test-repo-mod
# Go Vet
- id: go-vet-repo-mod
# GoSec
- id: go-sec-repo-mod

# Shell script hooks
- repo: https://github.com/cisagov/pre-commit-shfmt
rev: v0.0.2
Expand All @@ -83,7 +102,7 @@ repos:

# Python hooks
- repo: https://github.com/PyCQA/bandit
rev: 1.7.4
rev: 1.7.5
hooks:
- id: bandit
name: bandit (tests tree)
Expand All @@ -98,45 +117,45 @@ repos:
name: bandit (everything else)
exclude: tests
- repo: https://github.com/psf/black
rev: 22.3.0
rev: 23.3.0
hooks:
- id: black
- repo: https://gitlab.com/pycqa/flake8
rev: 3.9.2
- repo: https://github.com/PyCQA/flake8
rev: 6.0.0
hooks:
- id: flake8
additional_dependencies:
- flake8-docstrings
- repo: https://github.com/PyCQA/isort
rev: 5.10.1
rev: 5.12.0
hooks:
- id: isort
- repo: https://github.com/pre-commit/mirrors-mypy
rev: v0.942
rev: v1.3.0
hooks:
- id: mypy
- repo: https://github.com/asottile/pyupgrade
rev: v2.31.1
rev: v3.4.0
hooks:
- id: pyupgrade

# Ansible hooks
- repo: https://github.com/ansible-community/ansible-lint
rev: v5.4.0
rev: v6.17.0
hooks:
- id: ansible-lint
# files: molecule/default/playbook.yml

# Terraform hooks
- repo: https://github.com/antonbabenko/pre-commit-terraform
rev: v1.64.0
rev: v1.80.0
hooks:
- id: terraform_fmt
- id: terraform_validate

# Docker hooks
- repo: https://github.com/IamTheFij/docker-pre-commit
rev: v2.1.0
rev: v3.0.1
hooks:
- id: docker-compose-check

Expand Down
10 changes: 10 additions & 0 deletions .yamllint
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,16 @@ rules:
# this behavior.
comments-indentation: disable

# yamllint does not allow inline mappings that exceed the line length by
# default. There are many scenarios where the inline mapping may be a key,
# hash, or other long value that would exceed the line length but cannot
# reasonably be broken across lines.
line-length:
# This rule implies the allow-non-breakable-words rule
allow-non-breakable-inline-mappings: true
# Allows a 10% overage from the default limit of 80
max: 88

# yamllint doesn't like when we use yes and no for true and false,
# but that's pretty standard in Ansible.
truthy: disable
4 changes: 2 additions & 2 deletions setup-env
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ done
eval set -- "$PARAMS"

# Check to see if pyenv is installed
if [ -z "$(command -v pyenv)" ] || [ -z "$(command -v pyenv-virtualenv)" ]; then
if [ -z "$(command -v pyenv)" ] || { [ -z "$(command -v pyenv-virtualenv)" ] && [ ! -f "$(pyenv root)/plugins/pyenv-virtualenv/bin/pyenv-virtualenv" ]; }; then
echo "pyenv and pyenv-virtualenv are required."
if [[ "$OSTYPE" == "darwin"* ]]; then
cat << 'END_OF_LINE'
Expand Down Expand Up @@ -186,5 +186,5 @@ else:
END_OF_LINE
)"

# Qapla
# Qapla'
echo "Success!"