-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OpenGL loader to one generated by glad 0.1.36 #2332
base: master
Are you sure you want to change the base?
Conversation
totalgee
commented
Jun 18, 2024
- in a later step, we should update to glad2.
- in a later step, we should update to glad2.
I was actually intending to get rid of this build warning, that has annoyed me for ages with MSVC:
Unfortunately after going down the rabbit hole here of updating to the latest glad wrapper -- the last update was 071e776 in early 2020 -- I realized (too late) that what was needed was actually glad2 ...the latest version of glad (v1) doesn't fix the I spent some time trying to integrate the glad2-generated loader, but it has as slightly different API and I got a bit sidetracked trying to find a cross-platform Cinder-y way to get the "address loader" function, which needs to be passed to its initialization functions. Usually it's Thanks. |
Hey @totalgee thanks for working on updating the GL loader and sorry for being late to this game - I think most if not all of the non-crossplatform functions are resolved in Environment.h/cpp. Perhaps I can help figure out where best to resolve those handles like I do think it would be great to update to the latest loader as cinder will be using OpenGL as its fundamental graphics backend for some time to come still. Cheers, |
Here is a proposed permalink to the glad2 files (picking similar extensions as what we currently have): |
I found another way to get rid of the warning, which is very non-intrusive. If you agree @richardeakin, I can add it to the existing GLAD Cinder implementation (two added lines), or modify this PR and merge this newer (though still GLAD 1) version... The change is to put push/pop pragmas for
Now my projects compile clean without warnings...nice! |