Feature: Team mentor #28
Conversation
Signed-off-by: Jef Spaleta <[email protected]>
…excluded from reviews Signed-off-by: Jef Spaleta <[email protected]>
|
I should note. I've tested locally using the MillionDollarIdea github org. |
|
This work is related to cilium/community#178 |
Signed-off-by: Jef Spaleta <[email protected]>
jspaleta
force-pushed
the
jspaleta/feature/team-mentors
branch
from
6910cae to
e32cf9b
Compare
There was some rate limiting being applied. The returned error suggested the user to try out after a couple minutes, thus by adding a sleeper, we can re-try afterwards. Signed-off-by: André Martins <[email protected]>
Signed-off-by: André Martins <[email protected]>
…c team member/mentor without exposing entire configuration Signed-off-by: Jef Spaleta <[email protected]>
…am-mentors' into jspaleta/feature/team-mentors
|
I've extended this PR to include an optional team override file in the configuration. The team override file is a subset of the full Team configuration meant to be held in the public view while the full configuration is kept private. The TeamOverrideConfig includes only team names, and github usernames for team members and mentors. The team override file is a strict override of team member and mentor lists only on a per team basis, for teams intended to be managed in the public view. Once the CI build is complete I'll update the MillionDollarIdea repo with an example of the override in use. |
|
I now have the MillionDollarIdeas Org updated to make use of the proposed team override from the latest CI build of this PR. Public team information located at: Full Team management configuration located in private repo: repo-dispatch event is used to trigger private team-management workflow when public team membership info is updated. |
Signed-off-by: Jef Spaleta <[email protected]>
jspaleta
force-pushed
the
jspaleta/feature/team-mentors
branch
from
d6ead62 to
8e2a662
Compare
This pull request provides a working implementation to make it possible to use team-management tool in a more transparent way for Cilium project team memberships.
Highlights
Changes to introduce a mentor list to the TeamConfig to encode team members who want to be excluded from the review notification, simplifying the review exclusion process.
Introduction of a team override configuration intended to encode public team member/mentor information on a team by team basis while leaving the full configuration in a private repository.
This is strictly additive changes to how team manager tool operations. It does not interfere with the existing org wide
excludeCodeReviewAssignmentFromAllTeamsconfig or the team specificcodeReviewAssignment.excludedMembers. The intent is that these other mechanisms can be deprecated after configs are converted to using the team mentor concept, to ensure a smooth transition. Note: the github API doesn't let you query back which userIDs are currently excluded from review, so this is really just a matter of configuration state as a source of truth.Enhanced user status reporting by the
statusto indicate where in the team management config users are excluded.