WIP

cidgoh · Feb 3, 2025 · ba42d61 · ba42d61
1 parent 9c4facd
commit ba42d61
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/lib/toolbar.html b/lib/toolbar.html
@@ -463,6 +463,7 @@
       </div>
     </div>
   </div>
+
   <div class="modal fade" id="save-as-modal" tabindex="-1" role="dialog">
     <div class="modal-dialog" role="document">
       <div class="modal-content">
@@ -577,6 +578,7 @@
       </div>
     </div>
   </div>
+
   <div class="modal fade" id="export-to-modal" tabindex="-1" role="dialog">
     <div class="modal-dialog" role="document">
       <div class="modal-content">
@@ -635,6 +637,7 @@
       </div>
     </div>
   </div>
+
   <div class="modal fade" id="open-error-modal" tabindex="-1" role="dialog">
     <div class="modal-dialog" role="document">
       <div class="modal-content">
@@ -660,6 +663,7 @@
       </div>
     </div>
   </div>
+
   <div
     class="modal fade"
     id="upload-template-error-modal"
@@ -690,6 +694,7 @@
       </div>
     </div>
   </div>
+
   <div class="modal fade" id="jump-to-modal" tabindex="-1" role="dialog">
     <div class="modal-dialog" role="document">
       <div class="modal-content">

diff --git a/lib/utils/1m.js b/lib/utils/1m.js
@@ -792,9 +792,16 @@ export class OneToManyEventTracker extends EventTracker {
                   if (source === 'loadData' || !changes) return;
 
                   const rowChanges = changesToRows(changes);
+                  const columnIndex = dh.getColumnIndexByFieldName(foreign_key_slot);
                   const impactedRows = computeImpactedRows(rowChanges);
                   const hasDeleteActions = impactedRows.some(row => row.action === ACTION.DELETE);
-
+                  const isPrimaryKeyChange = changes.some(([row, col]) => col === columnIndex);
+
+                  if (isPrimaryKeyChange) {
+                      // TODO: check
+                      return false;
+                  }
+
                   if (hasDeleteActions) {
                     // WIP!
                     // Immediately return false to block the change
@@ -803,7 +810,7 @@ export class OneToManyEventTracker extends EventTracker {
                         // If the user confirmed, reapply the changes programmatically
                         changes.forEach(([row, col, oldValue, newValue]) => {
                           dh.hot.setSourceDataAtCell(row, col, newValue);
-                          dh.hot.setDataAtCell(row, col, newValue);
+                          // dh.hot.setDataAtCell(row, col, newValue);
                         });
                         // const newData = dh.hot.getData(); // get updated source data
                         // changes.forEach(([row, col, oldValue, newValue]) => {