Fix: improve device detection for touch screen laptops with high-DPI displays #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Waaiez is attempting to deploy a commit to the chroxify's team Team on Vercel. A member of the Team first needs to authorize it. |
chroxify
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was playing around with Haptic and was not happy with how scaled down the UI looks because of my ""fix"" in #14
Decided to just do a PR and fix the issue
Tested on my laptop with the scenarios I listed in the issue and this PR solves the issue
Double checked on my phone to make sure it still blocks mobile as it should
Current Haptic running at 2880x1800 and 175% scale, 80% zoom in Chrome
Haptic after the fix, same settings, just running at 100% zoom in Chrome
