Add a certificate with the TLSFeature extension specified by rfc 7633. #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| echo "Signing BadSSL.com must-staple Certificate" | ||
| openssl x509 -req -days 730 -sha256 -CAcreateserial \ | ||
| -in badssl-1000-sans.csr \ |
There was a problem hiding this comment.
You'll want to update this to be the correct CSR, I suspect. :)
|
Publicly-trusted certificates are now online: |
|
Nice. :-) PRs like this are still annoying to merge unless I have a real cert; @marumari I don't recall anymoer; were you poking Richard for a badssl.com one? |
|
I think you actually just needed to submit a CSR anytime starting Monday to Comodo. |
|
What about this PR? When will it get merged? I cannot reach https://must-staple-no-ocsp.serverhello.com and https://must-staple.serverhello.com. |
lgarron
force-pushed
the
master
branch
7 times, most recently
from
7bd393a to
ce37f31
Compare
lgarron
force-pushed
the
master
branch
2 times, most recently
from
c47918b to
785c007
Compare
lgarron
force-pushed
the
master
branch
3 times, most recently
from
903cb3b to
5affce5
Compare
lgarron
force-pushed
the
master
branch
3 times, most recently
from
7d8ea9f to
ae0f2c8
Compare
lgarron
force-pushed
the
master
branch
3 times, most recently
from
1d2c736 to
8b893ec
Compare
lgarron
force-pushed
the
master
branch
2 times, most recently
from
1dfcd2b to
9ca20c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue #17