Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crew-Launcher: Cannot add Firefox using package name or .desktop file #14

Open
aghebert opened this issue Oct 18, 2021 · 14 comments
Open

Comments

@aghebert
Copy link

Tried to add firefox installed from chromebrew using crew-launcher;
crew-launcher new firefox
The browser pops up asking "add to launcher", which adds a firefox icon to the chromeOS launcher. However, when the launcher icon is clicked, firefox does not start.

So I tried to add firefox using the .desktop file, but it kept saying firefox is not installed.

Screenshot 2021-10-18 14 27 20

Versions and system information

chromebrew: 1.17.5

ChromeOS:
CHROMEOS_RELEASE_BOARD=octopus-signed-mp-v31keys
CHROMEOS_RELEASE_BRANCH_NUMBER=77
CHROMEOS_RELEASE_BUILDER_PATH=octopus-release/R93-14092.77.0
CHROMEOS_RELEASE_BUILD_NUMBER=14092
CHROMEOS_RELEASE_BUILD_TYPE=Official Build
CHROMEOS_RELEASE_CHROME_MILESTONE=93
CHROMEOS_RELEASE_DESCRIPTION=14092.77.0 (Official Build) stable-channel octopus
CHROMEOS_RELEASE_KEYSET=mp-v31
CHROMEOS_RELEASE_NAME=Chrome OS
CHROMEOS_RELEASE_PATCH_NUMBER=0
CHROMEOS_RELEASE_TRACK=stable-channel
CHROMEOS_RELEASE_UNIBUILD=1
CHROMEOS_RELEASE_VERSION=14092.77.0
DEVICETYPE=CHROMEBOOK
GOOGLE_RELEASE=14092.77.0

Model: Acer Spin 512

Architecture: x86_64

@uberhacker
Copy link
Contributor

@aghebert: Does firefox start in your crosh shell? If not, that could be your issue.

@aghebert
Copy link
Author

aghebert commented Oct 18, 2021

Yes, it works. If I start Firefox using firefox in crosh shell, it will start normally.

@supechicken
Copy link
Member

supechicken commented Oct 19, 2021 via email

@aghebert
Copy link
Author

Those instructions don't work. I get this error when I click the firefox shortcut;

Screenshot 2021-10-29 11 01 02

I checked to make sure the server was running as well.

@supechicken
Copy link
Member

Since the crew-launcher new firefox command created a new profile for firefox, you need to install the shortcut once more (also the pwa) and use the new shortcut in the launcher (make sure that you are using the new shortcut :) )

@aghebert
Copy link
Author

aghebert commented Oct 30, 2021

I'm not sure I understand. I removed the old Firefox shortcut from crew-launcher, created a new Firefox shortcut using crew-launcher, and clicked on the new shortcut. What am I missing?

@uberhacker
Copy link
Contributor

@aghebert: Do you have any ad or popup blocker extensions enabled in your browser?

@supechicken
Copy link
Member

supechicken commented Oct 30, 2021

I'm not sure I understand. I removed the old Firefox shortcut from crew-launcher, created a new Firefox shortcut using crew-launcher, and clicked on the new shortcut. What am I missing?

Your steps are correct, could you provide the output of crew-launcher uuid firefox?

@aghebert
Copy link
Author

crew-launcher uuid firefox
15f6f48b-87f5-4664-bed7-916e78d08795

@aghebert
Copy link
Author

aghebert commented Oct 31, 2021

Update! Looks like i have leftover shortcut icons. I didn't realize this and was clicking on an older firefox shortcut. The newer one works!

EDIT: I take it back, seems like this shortcut is one and done. Can't get it to work after pinning it in the bar. Seems to launch a window, but that closes almost instantly and firefox does not start.

@supechicken
Copy link
Member

supechicken commented Oct 31, 2021

Update! Looks like i have leftover shortcut icons. I didn't realize this and was clicking on an older firefox shortcut. The newer one works!

EDIT: I take it back, seems like this shortcut is one and done. Can't get it to work after pinning it in the bar. Seems to launch a window, but that closes almost instantly and firefox does not start.

If the window closes immediately, we can confirm the shortcut itself is working :)
Seems that firefox is trying use Wayland to display instead of x11, could you try the following:

GDK_DISPLAY=x11
startsommelier
crew-launcher stop && crew-launcher start

The shortcut should work now

@uberhacker
Copy link
Contributor

uberhacker commented Nov 12, 2021

@aghebert: I just tested the new edge package and it works fine for me. Is your server running? What is the output of crew-launcher status? If not, run crew-launcher start and try to load firefox from the launcher. If this works then it might be a good idea to add crew-launcher start in your ~/.bashrc so the server starts when you login. EDIT: Actually, you don't need to add crew-launcher start to ~/.bashrc since /usr/local/etc/env.d/crew_launcher already does this for you.

@zeglol1234
Copy link

Can somebody tell me how to use --display, im lost here

@Zopolis4
Copy link
Collaborator

Zopolis4 commented May 13, 2024

This issue is probably better suited for the crew-launcher repo, right? Should someone transfer it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants