[ENH] Implement compactor server interface

idl/chromadb/proto/compactor.proto

@@ -0,0 +1,19 @@
+syntax = "proto3";
+
+package chroma;
+
+message CollectionIds {
+  repeated string ids = 1;
+}
+
+message CompactionRequest {
+  CollectionIds ids = 1;
+}
+
+message CompactionResponse {
+  // Empty
+}
+
+service Compactor {
+  rpc Compact(CompactionRequest) returns (CompactionResponse) {}
+}

rust/types/build.rs

@@ -2,6 +2,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
     // Compile the protobuf files in the chromadb proto directory.
     let mut proto_paths = vec![
         "../../idl/chromadb/proto/chroma.proto",
+        "../../idl/chromadb/proto/compactor.proto",
         "../../idl/chromadb/proto/coordinator.proto",
         "../../idl/chromadb/proto/logservice.proto",
         "../../idl/chromadb/proto/query_executor.proto",

rust/worker/src/compactor/compaction_manager.rs

@@ -1,7 +1,8 @@
 use super::scheduler::Scheduler;
 use super::scheduler_policy::LasCompactionTimeSchedulerPolicy;
+use super::OneOffCompactionMessage;
 use crate::compactor::types::CompactionJob;
-use crate::compactor::types::ScheduleMessage;
+use crate::compactor::types::ScheduledCompactionMessage;
 use crate::config::CompactionServiceConfig;
 use crate::execution::orchestration::CompactOrchestrator;
 use crate::execution::orchestration::CompactionResponse;
@@ -107,7 +108,7 @@ impl CompactionManager {
         let dispatcher = match self.dispatcher {
             Some(ref dispatcher) => dispatcher.clone(),
             None => {
-                println!("No dispatcher found");
+                tracing::error!("No dispatcher found");
                 return Err(Box::new(CompactionError::FailedToCompact));
             }
         };
@@ -139,7 +140,7 @@ impl CompactionManager {
                 }
             }
             None => {
-                println!("No system found");
+                tracing::error!("No system found");
                 return Err(Box::new(CompactionError::FailedToCompact));
             }
         };
@@ -158,19 +159,18 @@ impl CompactionManager {
             instrumented_span.follows_from(Span::current());
             jobs.push(self.compact(job).instrument(instrumented_span));
         }
-        println!("Compacting {} jobs", jobs.len());
         tracing::info!("Compacting {} jobs", jobs.len());
         let mut num_completed_jobs = 0;
         let mut num_failed_jobs = 0;
         while let Some(job) = jobs.next().await {
             match job {
                 Ok(result) => {
-                    println!("Compaction completed: {:?}", result);
+                    tracing::info!("Compaction completed: {:?}", result);
                     compacted.push(result.compaction_job.collection_id);
                     num_completed_jobs += 1;
                 }
                 Err(e) => {
-                    println!("Compaction failed: {:?}", e);
+                    tracing::info!("Compaction failed {}", e);
                     num_failed_jobs += 1;
                 }
             }
@@ -285,11 +285,13 @@ impl Component for CompactionManager {
     }
 
     async fn start(&mut self, ctx: &ComponentContext<Self>) -> () {
-        println!("Starting CompactionManager");
-        ctx.scheduler
-            .schedule(ScheduleMessage {}, self.compaction_interval, ctx, || {
-                Some(span!(parent: None, tracing::Level::INFO, "Scheduled compaction"))
-            });
+        tracing::info!("Starting CompactionManager");
+        ctx.scheduler.schedule(
+            ScheduledCompactionMessage {},
+            self.compaction_interval,
+            ctx,
+            || Some(span!(parent: None, tracing::Level::INFO, "Scheduled compaction")),
+        );
     }
 }
 
@@ -301,25 +303,40 @@ impl Debug for CompactionManager {
 
 // ============== Handlers ==============
 #[async_trait]
-impl Handler<ScheduleMessage> for CompactionManager {
+impl Handler<ScheduledCompactionMessage> for CompactionManager {
     type Result = ();
 
     async fn handle(
         &mut self,
-        _message: ScheduleMessage,
+        _message: ScheduledCompactionMessage,
         ctx: &ComponentContext<CompactionManager>,
     ) {
-        println!("CompactionManager: Performing compaction");
+        tracing::info!("CompactionManager: Performing compaction");
         let mut ids = Vec::new();
         self.compact_batch(&mut ids).await;
 
         self.hnsw_index_provider.purge_by_id(&ids).await;
 
         // Compaction is done, schedule the next compaction
-        ctx.scheduler
-            .schedule(ScheduleMessage {}, self.compaction_interval, ctx, || {
-                Some(span!(parent: None, tracing::Level::INFO, "Scheduled compaction"))
-            });
+        ctx.scheduler.schedule(
+            ScheduledCompactionMessage {},
+            self.compaction_interval,
+            ctx,
+            || Some(span!(parent: None, tracing::Level::INFO, "Scheduled compaction")),
+        );
+    }
+}
+
+#[async_trait]
+impl Handler<OneOffCompactionMessage> for CompactionManager {
+    type Result = ();
+    async fn handle(
+        &mut self,
+        _message: OneOffCompactionMessage,
+        _ctx: &ComponentContext<CompactionManager>,
+    ) {
+        tracing::info!("CompactionManager: Performing compaction");
+        todo!("To be implemented in next PR in the stack");
     }
 }
 

rust/worker/src/compactor/compaction_server.rs

@@ -0,0 +1,60 @@
+use async_trait::async_trait;
+use chroma_system::ComponentHandle;
+use chroma_types::chroma_proto::{
+    compactor_server::{Compactor, CompactorServer},
+    CompactionRequest, CompactionResponse,
+};
+use tokio::signal::unix::{signal, SignalKind};
+use tonic::{transport::Server, Request, Response, Status};
+use tracing::trace_span;
+
+use crate::compactor::OneOffCompactionMessage;
+
+use super::CompactionManager;
+
+pub struct CompactionServer {
+    pub manager: ComponentHandle<CompactionManager>,
+    pub port: u16,
+}
+
+impl CompactionServer {
+    pub async fn run(self) -> Result<(), Box<dyn std::error::Error>> {
+        let addr = format!("[::]:{}", self.port).parse().unwrap();
+        tracing::info!("Compaction server listing at {addr}");
+        let server = Server::builder().add_service(CompactorServer::new(self));
+        server
+            .serve_with_shutdown(addr, async {
+                match signal(SignalKind::terminate()) {
+                    Ok(mut sigterm) => {
+                        sigterm.recv().await;
+                        tracing::info!("Received SIGTERM, shutting down")
+                    }
+                    Err(err) => {
+                        tracing::error!("Failed to create SIGTERM handler: {err}")
+                    }
+                }
+            })
+            .await?;
+        Ok(())
+    }
+}
+
+#[async_trait]
+impl Compactor for CompactionServer {
+    async fn compact(
+        &self,
+        request: Request<CompactionRequest>,
+    ) -> Result<Response<CompactionResponse>, Status> {
+        let compaction_span = trace_span!("CompactionRequest", request = ?request);
+        self.manager
+            .receiver()
+            .send(
+                OneOffCompactionMessage::try_from(request.into_inner())
+                    .map_err(|e| Status::invalid_argument(e.to_string()))?,
+                Some(compaction_span),
+            )
+            .await
+            .map_err(|e| Status::internal(e.to_string()))?;
+        Ok(Response::new(CompactionResponse {}))
+    }
+}

rust/worker/src/compactor/mod.rs

@@ -6,3 +6,5 @@ mod types;
 
 pub(crate) use compaction_manager::*;
 pub(crate) use types::*;
+
+pub mod compaction_server;

rust/worker/src/compactor/types.rs

@@ -9,4 +9,10 @@ pub(crate) struct CompactionJob {
 }
 
 #[derive(Clone, Debug)]
-pub(crate) struct ScheduleMessage {}
+pub struct ScheduledCompactionMessage {}
+
+#[derive(Clone, Debug)]
+pub struct OneOffCompactionMessage {
+    #[allow(dead_code)]
+    pub collection_ids: Vec<CollectionUuid>,
+}

rust/worker/src/lib.rs

@@ -6,6 +6,7 @@ mod tracing;
 mod utils;
 
 use chroma_config::Configurable;
+use compactor::compaction_server::CompactionServer;
 use memberlist::MemberlistProvider;
 
 use tokio::select;
@@ -131,6 +132,15 @@ pub async fn compaction_service_entrypoint() {
 
     let mut memberlist_handle = system.start_component(memberlist);
 
+    let compaction_server = CompactionServer {
+        manager: compaction_manager_handle.clone(),
+        port: config.my_port,
+    };
+
+    let server_join_handle = tokio::spawn(async move {
+        let _ = CompactionServer::run(compaction_server).await;
+    });
+
     let mut sigterm = match signal(SignalKind::terminate()) {
         Ok(sigterm) => sigterm,
         Err(e) => {
@@ -151,6 +161,7 @@ pub async fn compaction_service_entrypoint() {
             let _ = compaction_manager_handle.join().await;
             system.stop().await;
             system.join().await;
+            let _ = server_join_handle.await;
         },
     };
     println!("Server stopped");

rust/worker/src/utils/convert.rs

@@ -1,14 +1,19 @@
+use std::str::FromStr;
+
 use chroma_types::{
     chroma_proto::{self, GetResult, KnnBatchResult, KnnResult},
-    ConversionError, ScalarEncoding, Where,
+    CollectionUuid, ConversionError, ScalarEncoding, Where,
 };
 
-use crate::execution::operators::{
-    filter::FilterOperator,
-    knn::KnnOperator,
-    knn_projection::{KnnProjectionOperator, KnnProjectionOutput, KnnProjectionRecord},
-    limit::LimitOperator,
-    projection::{ProjectionOperator, ProjectionOutput, ProjectionRecord},
+use crate::{
+    compactor::OneOffCompactionMessage,
+    execution::operators::{
+        filter::FilterOperator,
+        knn::KnnOperator,
+        knn_projection::{KnnProjectionOperator, KnnProjectionOutput, KnnProjectionRecord},
+        limit::LimitOperator,
+        projection::{ProjectionOperator, ProjectionOutput, ProjectionRecord},
+    },
 };
 
 impl TryFrom<chroma_proto::FilterOperator> for FilterOperator {
@@ -110,7 +115,7 @@ impl TryFrom<KnnProjectionRecord> for chroma_proto::KnnProjectionRecord {
     type Error = ConversionError;
 
     fn try_from(value: KnnProjectionRecord) -> Result<Self, ConversionError> {
-        Ok(chroma_proto::KnnProjectionRecord {
+        Ok(Self {
             record: Some(value.record.try_into()?),
             distance: value.distance,
         })
@@ -121,7 +126,7 @@ impl TryFrom<KnnProjectionOutput> for KnnResult {
     type Error = ConversionError;
 
     fn try_from(value: KnnProjectionOutput) -> Result<Self, ConversionError> {
-        Ok(KnnResult {
+        Ok(Self {
             records: value
                 .records
                 .into_iter()
@@ -154,3 +159,20 @@ pub fn to_proto_knn_batch_result(
             .collect::<Result<_, _>>()?,
     })
 }
+
+impl TryFrom<chroma_proto::CompactionRequest> for OneOffCompactionMessage {
+    type Error = ConversionError;
+
+    fn try_from(value: chroma_proto::CompactionRequest) -> Result<Self, ConversionError> {
+        Ok(Self {
+            collection_ids: value
+                .ids
+                .ok_or(ConversionError::DecodeError)?
+                .ids
+                .into_iter()
+                .map(|id| CollectionUuid::from_str(&id))
+                .collect::<Result<_, _>>()
+                .map_err(|_| ConversionError::DecodeError)?,
+        })
+    }
+}