Manual compaction must specify collection id

chroma-core · Jan 21, 2025 · b9521bc · b9521bc
1 parent 77b5ab5
commit b9521bc
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/idl/chromadb/proto/compactor.proto b/idl/chromadb/proto/compactor.proto
@@ -7,7 +7,7 @@ message CollectionIds {
 }
 
 message CompactionRequest {
-  optional CollectionIds ids = 1;
+  CollectionIds ids = 1;
 }
 
 message CompactionResponse {

diff --git a/rust/worker/src/compactor/types.rs b/rust/worker/src/compactor/types.rs
@@ -14,5 +14,5 @@ pub struct ScheduledCompactionMessage {}
 #[derive(Clone, Debug)]
 pub struct OneOffCompactionMessage {
     #[allow(dead_code)]
-    pub collection_ids: Option<Vec<CollectionUuid>>,
+    pub collection_ids: Vec<CollectionUuid>,
 }
diff --git a/rust/worker/src/utils/convert.rs b/rust/worker/src/utils/convert.rs
@@ -167,13 +167,11 @@ impl TryFrom<chroma_proto::CompactionRequest> for OneOffCompactionMessage {
         Ok(Self {
             collection_ids: value
                 .ids
-                .map(|ids| {
-                    ids.ids
-                        .into_iter()
-                        .map(|id| CollectionUuid::from_str(&id))
-                        .collect::<Result<_, _>>()
-                })
-                .transpose()
+                .ok_or(ConversionError::DecodeError)?
+                .ids
+                .into_iter()
+                .map(|id| CollectionUuid::from_str(&id))
+                .collect::<Result<_, _>>()
                 .map_err(|_| ConversionError::DecodeError)?,
         })
     }