This pull request allows people to select boost::future over std::future #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The exception handling wasn't working right. boost::promise doesn't handle std::exception_ptr well. |
|
I also added support for passing in an error_code * to use_future_t so that you can retrieve an error without throwing an exception on a call to get() or co_await |
Though it looks like they would fail without my merge
|
This works as well as I can make it. The integration tests are now failing because of the |
karzhenkov
added a commit
to karzhenkov/asio-primary
that referenced
this pull request
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed continuation which std::future doesn't have.
simply
#define ASIO_DISABLE_STD_FUTURE
and it ill fail over to boost::future|promise|packaged_task unless ASIO_DISABLE_BOOST_FUTURE is also defined.