[Py3] Support relative and package imports #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Py3 drops the cPickle library. This ensure's it's not used if it doesn't exist. re: #33
The update called in the context of the plugin and its own shell. These context have different package paths. The plugin must import through relative paths, while the shell must import through package paths. This change ensures both context work. There's probably a more elegant way of resolving this issue. ;) The change also reverse the circular import fix to make resolving the relative import in Py3 easier since the fix can exist in oneplace rather than multiple imports statements. re: #33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update called in the context of the plugin and its own shell. These context have different package paths. The plugin must import through relative paths, while the shell must import through package paths. This change ensures both context work.
There's probably a more elegant way of resolving this issue. ;)
The change also reverse the circular import fix to make resolving the relative import in Py3 easier since the fix can exist in oneplace rather than multiple imports statements.
re: #33
This PR is dependent on #36 and thus based off its branch. It'll be easier to review this after the dependent PR is merged.
This PR is part of a collection of changes to support Python3. The collection is broken into multiple stages. This change is part of stage 2 and should be safe to merge after all the changes from stage 2 are merged.