[Py3] Open background forks std{in,out,err} in binary mode #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following exception is thrown when running under Py3:
14:34:23 workflow.py:2542 INFO Checking for update ...
14:34:23 workflow.py:2275 ERROR can't have unbuffered text I/O
Traceback (most recent call last):
File "/Volumes/Files/Private/Projects/bear-alfred-plugin/alfred-bear/workflow/workflow.py", line 2268, in run
func(self)
File "/Volumes/Files/Private/Projects/bear-alfred-plugin/alfred-bear/workflow/background.py", line 217, in main
_background()
File "/Volumes/Files/Private/Projects/bear-alfred-plugin/alfred-bear/workflow/background.py", line 132, in _background
si = open(stdin, 'r', 0)
ValueError: can't have unbuffered text I/O
This change resolves the issue by switching the open from text to binary.
Binary mode doesn't require a buffer so the exception isn't thrown.
re: #33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following exception is thrown when running under Py3:
This change resolves the issue by switching the open from text to binary. Binary mode doesn't require a buffer so the exception isn't thrown.
This PR is part of a collection of changes to support Python3. The collection is broken into multiple stages. This change is part of stage 1 and should be safe to merge at any time.
re: #33