Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it is impossible to install simstring Python bindings directly from
pip
(e.g. via apip-requirements.txt
file in a project). It is currently necessary to manually clone the repository, run configure, enter the Python bindings directory, runprepare.sh
, to finally be able to runsetup.py
orpip
.This patches fixes this issue by:
setup.py.in
tosetup.py
, removing thus the need to previously runconfigure
. The package name is now static and the version is obtained by reading theconfigure.in
file.setup.py
so that it callsprepare.sh
automatically as a pre-hook.Besides that, this patch also:
prepare.sh
error reporting, so that the user gets a meaningful error message if swig is missing from the system.-liconv -lpython
fromextra_link_args
. It is not necessary anymore to explicitly include these libraries (you can just assume they are loaded) - tested in Ubuntu LTS and Arch Linux. By removing them, simstring can be built for PyPy.After this patch is merged, one will be able to install using
pip
by including the following line in theirpip-requirements.txt
file:(you can test with my fork if you want to test before merging)