Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Probes Section cleanup #154

Merged
merged 11 commits into from
Dec 13, 2023
Merged

[patch] Probes Section cleanup #154

merged 11 commits into from
Dec 13, 2023

Conversation

mmaloney-sf
Copy link
Collaborator

Organize and clean up the section on probes after they were disrupted by #143 and #145.

@mmaloney-sf mmaloney-sf changed the title Add outline for probes rewrite. Rename old section Probes (OLD). [patch] Probes Section cleanup Nov 15, 2023
@mmaloney-sf mmaloney-sf force-pushed the mmaloney/probes-rewrite branch from 318281e to c85bd26 Compare November 16, 2023 15:02
@mmaloney-sf mmaloney-sf force-pushed the mmaloney/probes-rewrite branch from 8888725 to a31e359 Compare December 4, 2023 21:10
spec.md Outdated Show resolved Hide resolved
spec.md Show resolved Hide resolved
spec.md Show resolved Hide resolved
spec.md Outdated Show resolved Hide resolved
spec.md Outdated Show resolved Hide resolved
mmaloney-sf and others added 2 commits December 4, 2023 14:53
Co-authored-by: Megan Wachs <[email protected]>
spec.md Show resolved Hide resolved
@mmaloney-sf mmaloney-sf marked this pull request as ready for review December 4, 2023 21:57
spec.md Outdated Show resolved Hide resolved
spec.md Outdated Show resolved Hide resolved
Copy link
Member

@dtzSiFive dtzSiFive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Made pass with some feedback/nits.

spec.md Show resolved Hide resolved
spec.md Show resolved Hide resolved
spec.md Show resolved Hide resolved
spec.md Show resolved Hide resolved
spec.md Show resolved Hide resolved
spec.md Show resolved Hide resolved
spec.md Show resolved Hide resolved
spec.md Show resolved Hide resolved
Co-authored-by: Megan Wachs <[email protected]>
@mmaloney-sf mmaloney-sf merged commit 34c18fc into main Dec 13, 2023
1 check passed
@mmaloney-sf mmaloney-sf deleted the mmaloney/probes-rewrite branch December 13, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants