Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate PriorityMux and Mux1H Seq size errors #4609

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

jackkoenig
Copy link
Contributor

All I wanted to do was aggregate errors, but in for a penny, in for a pound.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • API Modification

Desired Merge Strategy

  • Squash

Release Notes

  • This requires adding source locators to PriorityMux and Mux1H which requires SourceInfoTransform macros in Scala 2 and thus splitting the Scala 2 / Scala 3 public interfaces.
  • Because macro applications do not support named arguments in Scala 2, this is an API change.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

This requires adding source locators to PriorityMux and Mux1H which
requires SourceInfoTransform macros in Scala 2 and thus splitting the
Scala 2 / Scala 3 public interfaces.

Because macro applications do not support named arguments in Scala 2,
this is an API change.
@jackkoenig jackkoenig added this to the 7.0 milestone Jan 9, 2025
@jackkoenig jackkoenig requested a review from mwachs5 January 9, 2025 23:45
Copy link
Contributor

@mikeurbach mikeurbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little out of the loops on the scala 2 vs. 3 splits, but this seems reasonable to me.

@jackkoenig jackkoenig merged commit 0d73982 into main Jan 10, 2025
18 checks passed
@jackkoenig jackkoenig deleted the jackkoenig/aggregate-mux-errors branch January 10, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants