Support boring on original Module after .toInstance call #4602
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that simply using the "current ports" in Lookupable is totally fine. It's not possible to see BoringUtils introduced ports via
@public
so their visibility in the ports seen by Lookupable is irrelevant.I waffled on if I think this should be legal or not. What eventually convinced me was the following: One of the main reasons
.toInstance
exists is to write generators that work with both normalModules
and with D/IInstances
. What is the purpose of such parameterization in a generator? Obviously, this exists because the user may want to do things that only Modules can do (i.e., that don't work on Instances). One of the most common things in this category is boring, which you can do to Modules but obviously cannot do to Instances. Thus we should make sure it's allowed. I will also note that @azidar in the original PR barred boring after calling.toDefinition
, but [I'm assuming] deliberately did not bar it after.toInstance
.Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.6.x
,5.x
, or6.x
depending on impact, API modification or big change:7.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.