Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix up extra waveform dump behavior in svsim (backport #4592) #4600

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 7, 2025

When added require statement in ChiselSim/svsim, the delay value will be set to 0, which will cause an extra dump waveform behavior. So we only call eval_step once to update the design model.

This will fix #4516.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

This is an automatic backport of pull request #4592 done by [Mergify](https://mergify.com).

When added require statement in ChiselSim/svsim, the delay value will be
set to 0, which will cause an extra dump waveform behavior. So we only
call `eval_step` once to update the design model

(cherry picked from commit 3380196)
@mergify mergify bot added the Backport Automated backport, please consider for minor release label Jan 7, 2025
@github-actions github-actions bot added the Bugfix Fixes a bug, will be included in release notes label Jan 7, 2025
@chiselbot chiselbot merged commit 158d66b into 6.x Jan 7, 2025
17 checks passed
@chiselbot chiselbot deleted the mergify/bp/6.x/pr-4592 branch January 7, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport Automated backport, please consider for minor release Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants