Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error rather than throw on scope violations #4586

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

jackkoenig
Copy link
Contributor

I am making changes that are tripping scope issues and it was very annoying. I did this work to help myself so it probably belongs in upstream!

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • API modification

Desired Merge Strategy

  • Squash

Release Notes

  • Errors are aggregated by default and all reported at the end whereas exceptions throw immediately. This allows users to fix multiple scope violations at the same time.
  • Printable.unpack now takes an implicit SourceInfo
  • PropertyType.convertUnderlying now takes an explicit SourceInfo

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added this to the 7.0 milestone Jan 2, 2025
Errors are aggregated by default and all reported at the end whereas
exceptions throw immediately. This allows users to fix multiple scope
violations at the same time.
@jackkoenig jackkoenig force-pushed the jackkoenig/scope-error-dont-throw branch from 27aa9d9 to 2d42d59 Compare January 2, 2025 21:38
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I lightly reviewed this. The general direction makes a ton of sense. Great idea.

@jackkoenig jackkoenig merged commit c3713ef into main Jan 3, 2025
15 checks passed
@jackkoenig jackkoenig deleted the jackkoenig/scope-error-dont-throw branch January 3, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants