Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIRCT converter: rename portSyms to portSymbols #4584

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

SpriteOvO
Copy link
Member

Follow up the upstream PR llvm/circt#7734.

@SpriteOvO SpriteOvO added the No Release Notes Exclude from release notes, consider using Internal instead label Dec 30, 2024
@SpriteOvO SpriteOvO requested a review from sequencer December 30, 2024 22:00
@SpriteOvO SpriteOvO force-pushed the bump-circt-converter branch from 279d782 to 2537b00 Compare December 31, 2024 19:09
@sequencer
Copy link
Member

tests still failed with:

[430/430] lit[2.13.15].run
[lit] -- Testing: 7 tests, 7 workers --
[lit] PASS: CHISEL :: Property/Bad.sc (1 of 7)
[lit] PASS: CHISEL :: Converter/Circuit.sc (2 of 7)
[lit] PASS: CHISEL :: Converter/Debug.sc (3 of 7)
[lit] PASS: CHISEL :: Converter/Module.sc (4 of 7)
[lit] FAIL: CHISEL :: Property/DocExample.sc (5 of 7)
[lit] PASS: CHISEL :: Property/Good.sc (6 of 7)
[lit] PASS: CHISEL :: SmokeTest.sc (7 of 7)
[lit] ********************
[lit] Failed Tests (1):
[lit]   CHISEL :: Property/DocExample.sc
[lit]
[lit]
[lit] Testing Time: 42.93s
[lit]
[lit] Total Discovered Tests: 7
[lit]   Passed: 6 (85.71%)
[lit]   Failed: 1 (14.29%)

@SpriteOvO
Copy link
Member Author

@sequencer Can you provide the failure logs? I cannot reproduce it on my machine.

[473/860] lit[2.13.15].run 
[lit] -- Testing: 7 tests, 7 workers --
[lit] PASS: CHISEL :: Property/Bad.sc (1 of 7)
[lit] PASS: CHISEL :: Converter/Circuit.sc (2 of 7)
[lit] PASS: CHISEL :: Converter/Debug.sc (3 of 7)
[lit] PASS: CHISEL :: Converter/Module.sc (4 of 7)
[lit] PASS: CHISEL :: Property/DocExample.sc (5 of 7)
[lit] PASS: CHISEL :: Property/Good.sc (6 of 7)
[lit] PASS: CHISEL :: SmokeTest.sc (7 of 7)
[lit] 
[lit] Testing Time: 26.75s
[lit] 
[lit] Total Discovered Tests: 7
[lit]   Passed: 7 (100.00%)

Copy link
Member

@sequencer sequencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It must be a cosmic ray:( It now passed on my side at the same environment. we should add CI for lit.

@sequencer sequencer merged commit e461069 into main Jan 2, 2025
15 checks passed
@sequencer sequencer deleted the bump-circt-converter branch January 2, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Release Notes Exclude from release notes, consider using Internal instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants