[ChiselSim][svsim] Switch to shouldIncludeFile #4557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide initial work that better handles the problem of needing to filter files in order to enable specific layers. This adds a new member function, `shouldIncludeFile` which returns a `PartialFunction` that is defined only if the file being examined is a layer file (as defined in the FIRRTL ABI for extract layers) and returns true if that layer file should be included in order to enable the requested layers. In subsequent commits, this will be made load bearing. Signed-off-by: Schuyler Eldridge <[email protected]>
Change both ChiselSim and svsim to no longer use the `filter` function of `LayerControl`. Migrate both to use `shouldIncludeFile` partial function. The latter is a much better API as it reserves the handling of files that are outside the domain of the filter to ChiselSim and svsim. Signed-off-by: Schuyler Eldridge <[email protected]>
Remove `LayerControl`'s filter as this is no longer load-bearing. Signed-off-by: Schuyler Eldridge <[email protected]>
seldridge
added
the
No Release Notes
seldridge
deleted the
dev/seldridge/refactor-chiselsim-extract-layers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide initial work that better handles the problem of needing to filter
files in order to enable specific layers. This adds a new member
function,
shouldIncludeFilewhich returns aPartialFunctionthat isdefined only if the file being examined is a layer file (as defined in the
FIRRTL ABI for extract layers) and returns true if that layer file should
be included in order to enable the requested layers.
Change both ChiselSim and svsim to no longer use the
filterfunction ofLayerControl. Migrate both to useshouldIncludeFilepartial function.The latter is a much better API as it reserves the handling of files that
are outside the domain of the filter to ChiselSim and svsim.
Remove
LayerControl's filter as this is no longer load-bearing.