[test] Switch to new inline layer ABI #4550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `LayerSpec` to use the new inline layer ABI. This uses '$' as a delimiter instead of '_' in order to avoid ambiguity related to layer names which may contain '_'. Signed-off-by: Schuyler Eldridge <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
Change `LayerSpec` to use the new inline layer ABI. This uses '$' as a delimiter instead of '_' in order to avoid ambiguity related to layer names which may contain '_'. Signed-off-by: Schuyler Eldridge <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Dec 7, 2024
Change `LayerSpec` to use the new inline layer ABI. This uses '$' as a delimiter instead of '_' in order to avoid ambiguity related to layer names which may contain '_'. Signed-off-by: Schuyler Eldridge <[email protected]>
chiselbot
pushed a commit
that referenced
this pull request
Dec 8, 2024
Change `LayerSpec` to use the new inline layer ABI. This uses '$' as a delimiter instead of '_' in order to avoid ambiguity related to layer names which may contain '_'. Signed-off-by: Schuyler Eldridge <[email protected]>
seldridge
added a commit
that referenced
this pull request
Dec 8, 2024
* [cd] Bump CIRCT from firtool-1.96.0 to firtool-1.97.1 This is an automated commit generated by the `circt/update-circt` GitHub Action. * [test] Add Verilog test of inline emission, NFC Add an integration test of SystemVerilog generation for inline layers. This relies on new support in firtool 1.97.0 which adds support for compiling this feature. Previous versions of firtool could parse inline layers, but error when compiling them. * [test] Switch to new inline layer ABI (#4550) Change `LayerSpec` to use the new inline layer ABI. This uses '$' as a delimiter instead of '_' in order to avoid ambiguity related to layer names which may contain '_'. This now also includes the circuit name and a leading 'layer_'. * [test] Update btor2 emission test There was a change in the btor2 emission upstream. Update the test to match the new emission. I did not validate the correctness of this change. Signed-off-by: Schuyler Eldridge <[email protected]> Co-authored-by: Schuyler Eldridge <[email protected]> Co-authored-by: chiselbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
LayerSpecto use the new inline layer ABI. This uses '$' as a delimiter instead of '' in order to avoid ambiguity related to layer names which may contain ''.