Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CD permissions for uploading release artifacts #4529

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

jackkoenig
Copy link
Contributor

These actions failed for v6.6.0, Github now requires explicit permissions to push to releases, see https://github.com/softprops/action-gh-release?tab=readme-ov-file#permissions.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Internal or build-related (includes code refactoring/cleanup)

Desired Merge Strategy

  • Squash

Release Notes

Also bump softprops/action-gh-release to v2.1.0.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

Also bump softprops/action-gh-release to v2.1.0.
@jackkoenig jackkoenig added the Internal Internal change, does not affect users, will be included in release notes label Nov 26, 2024
@jackkoenig jackkoenig added this to the 5.x milestone Nov 26, 2024
@jackkoenig jackkoenig enabled auto-merge (squash) November 26, 2024 19:35
@jackkoenig jackkoenig merged commit 25d00af into main Nov 26, 2024
18 checks passed
@jackkoenig jackkoenig deleted the cd-permissions branch November 26, 2024 19:42
@mergify mergify bot added the Backported This PR has been backported label Nov 26, 2024
mergify bot pushed a commit that referenced this pull request Nov 26, 2024
Also bump softprops/action-gh-release to v2.1.0.

(cherry picked from commit 25d00af)

# Conflicts:
#	.github/workflows/release-notes.yml
#	.github/workflows/scala-cli-example.yml
mergify bot pushed a commit that referenced this pull request Nov 26, 2024
Also bump softprops/action-gh-release to v2.1.0.

(cherry picked from commit 25d00af)
chiselbot pushed a commit that referenced this pull request Nov 26, 2024
Also bump softprops/action-gh-release to v2.1.0.

(cherry picked from commit 25d00af)

Co-authored-by: Jack Koenig <[email protected]>
chiselbot pushed a commit that referenced this pull request Nov 27, 2024
#4530)

* Update CD permissions for uploading release artifacts (#4529)

Also bump softprops/action-gh-release to v2.1.0.

(cherry picked from commit 25d00af)

# Conflicts:
#	.github/workflows/release-notes.yml
#	.github/workflows/scala-cli-example.yml

* Update release-notes.yml

* Update scala-cli-example.yml

---------

Co-authored-by: Jack Koenig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported Internal Internal change, does not affect users, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants