Code review updates

chipsalliance · Dec 19, 2024 · d754f9f · d754f9f
1 parent dfd3245
commit d754f9f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/core/src/main/scala-3/chisel3/Module.scala b/core/src/main/scala-3/chisel3/Module.scala
@@ -15,8 +15,7 @@ object Module extends ObjectModuleImpl with SourceInfoDoc {
     */
   // TODO(adkian-sifive) the callsite here explicitly passes
   // sourceInfo so it cannot be a contextual parameter
-  def apply[T <: BaseModule](bc:    => T): T = _applyImpl(bc)
-  def do_apply[T <: BaseModule](bc: => T)(implicit sourceInfo: SourceInfo): T = apply(bc)
+  def apply[T <: BaseModule](bc: => T): T = _applyImpl(bc)
 }
 
 /** Abstract base class for Modules, which behave much like Verilog modules.

diff --git a/core/src/main/scala/chisel3/ModuleImpl.scala b/core/src/main/scala/chisel3/ModuleImpl.scala
@@ -31,7 +31,7 @@ import chisel3.experimental.hierarchy.Hierarchy
 
 private[chisel3] trait ObjectModuleImpl {
 
-  protected def _applyImpl[T <: BaseModule](bc: => T)(implicit sourceInfo: SourceInfo): T = {
+  protected[chisel3] def _applyImpl[T <: BaseModule](bc: => T)(implicit sourceInfo: SourceInfo): T = {
     // Instantiate the module definition.
     val module: T = evaluate[T](bc)
 

diff --git a/core/src/main/scala/chisel3/internal/package.scala b/core/src/main/scala/chisel3/internal/package.scala
@@ -130,7 +130,7 @@ package object internal {
     * @note this is a lazy val so that calling functions in this package object doesn't create it
     */
   private[chisel3] lazy val ViewParent =
-    Module.do_apply(new ViewParentAPI)(UnlocatableSourceInfo)
+    Module._applyImpl(new ViewParentAPI)(UnlocatableSourceInfo)
 
   private[chisel3] def requireHasProbeTypeModifier(
     probe:        Data,