fix: evaluate target lazily in Path

At the moment `toTarget` does not work properly with the D/I system, seeing that we cannot get the instanceName of a module when evaluating it, and even if we call `toTarget` in `atModuleBodyEnd` we will get the wrong circuit name since the definition of the module's parent is still in construction. In order to construct `Path` properly, we need to defer the evaluation of `target` to the IR generation time in the `isMember` constructor, just as the other constructors already do. Signed-off-by: unlsycn <[email protected]>
chipsalliance · Dec 2, 2024 · 2b17841 · 2b17841
1 parent e12a1ef
commit 2b17841
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/core/src/main/scala/chisel3/properties/Path.scala b/core/src/main/scala/chisel3/properties/Path.scala
@@ -106,8 +106,8 @@ object Path {
 
   /** Construct a Path from a target
     */
-  def apply(target: IsMember): Path = apply(target, false)
-  def apply(target: IsMember, isMemberPath: Boolean): Path = {
+  def apply(target: => IsMember): Path = apply(target, false)
+  def apply(target: => IsMember, isMemberPath: Boolean): Path = {
     val _isMemberPath = isMemberPath // avoid name shadowing below
     new TargetPath {
       def toTarget():   IsMember = target