chore: throws on non-found variable name

cheminfo · Nov 3, 2016 · af856e6 · af856e6
1 parent 02171c8
commit af856e6
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/index.js b/src/index.js
@@ -101,6 +101,9 @@ class NetCDFReader {
             variable = variableName;
         }
 
+        // throws if variable not found
+        utils.notNetcdf((variable === undefined), 'variable not found');
+
         // go to the offset position
         this.buffer.seek(variable.offset);
 

diff --git a/test/test.js b/test/test.js
@@ -107,7 +107,7 @@ describe('Read file', function () {
         record[2].should.be.equal(71408);
     });
 
-    it('read record variable with object', function () {
+    it('read non-record variable with object', function () {
         const data = fs.readFileSync(pathFiles + 'madis-sao.nc');
         var reader = new NetCDFReader(data);
         var variables = reader.variables;
@@ -121,4 +121,12 @@ describe('Read file', function () {
         withString[1].should.be.equal(withObject[1]);
         withString[2].should.be.equal(withObject[2]);
     });
+
+    it('read non-existent variable string', function () {
+        const data = fs.readFileSync(pathFiles + 'madis-sao.nc');
+        var reader = new NetCDFReader(data);
+
+        reader.getDataVariable.bind(reader, 'n\'importe quoi')
+            .should.throw('Not a valid NetCDF v3.x file: variable not found');
+    });
 });