Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of API calls for cookbook_artifacts end point #21

Merged
merged 3 commits into from
Apr 17, 2020

Conversation

mudash
Copy link

@mudash mudash commented Apr 16, 2020

These changes add functionality for implementation of API calls for cookbook_artifacts end point

Description

/cookbook_artifacts end point implementation is needed to fetch cookbooks that are available on Chef Server via Policy Files. /cookbooks end point doesn't give access to these cookbooks

Related Issue

https://app.zenhub.com/workspaces/chef-workstation-5c0aced04b5806bc2bfb9347/issues/chef/go-chef/19

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Copy link

@clintoncwolfe clintoncwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Signed-off-by: Mudassar Shafique <[email protected]>
Copy link

@tyler-ball tyler-ball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mudash!

@@ -3,14 +3,37 @@ module github.com/chef/go-chef
go 1.12

require (
github.com/aws/aws-sdk-go v1.30.7 // indirect

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these dependencies are pulled in for the integration tests. I would love to have those tests pull their own dependencies in with their own go.mod but I think we fix that in #15

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Thanks @tyler-ball

@mudash mudash merged commit 745576d into master Apr 17, 2020
@mudash mudash deleted the issue9/cookbook_artifacts branch April 17, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants