-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of API calls for cookbook_artifacts end point #21
Conversation
Signed-off-by: Mudassar Shafique <[email protected]>
Signed-off-by: Mudassar Shafique <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Signed-off-by: Mudassar Shafique <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mudash!
@@ -3,14 +3,37 @@ module github.com/chef/go-chef | |||
go 1.12 | |||
|
|||
require ( | |||
github.com/aws/aws-sdk-go v1.30.7 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of these dependencies are pulled in for the integration tests. I would love to have those tests pull their own dependencies in with their own go.mod
but I think we fix that in #15
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Thanks @tyler-ball
These changes add functionality for implementation of API calls for
cookbook_artifacts
end pointDescription
/cookbook_artifacts
end point implementation is needed to fetch cookbooks that are available on Chef Server via Policy Files./cookbooks
end point doesn't give access to these cookbooksRelated Issue
https://app.zenhub.com/workspaces/chef-workstation-5c0aced04b5806bc2bfb9347/issues/chef/go-chef/19
Types of changes
Checklist: