Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add invalid attempts #43

Open
wants to merge 57 commits into
base: add_request_validators
Choose a base branch
from
Open

Add invalid attempts #43

wants to merge 57 commits into from

Conversation

iamazzeez
Copy link
Collaborator

@iamazzeez iamazzeez commented Mar 30, 2022 •
edited
Loading

https://chefio.atlassian.net/browse/KINETICS-66
https://chefio.atlassian.net/browse/KINETICS-67
https://chefio.atlassian.net/browse/KINETICS-68
https://chefio.atlassian.net/browse/KINETICS-79
https://chefio.atlassian.net/browse/KINETICS-73

Overview

What this PR does / why we need it

This PR creates blocked_user table in dex psql db
This is needed to accommodate failed login attempts with valid username

Special notes for your reviewer

Does this PR introduce a user-facing change?

iamazzeez added 11 commits March 25, 2022 11:48
@iamazzeez
added logs
be56c52 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez
added blocked_user talble
3137215 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez
createblockeduser type fix
67b0bc9 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez
added test cases
7f0ff86 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez
added test cases
05d24a6 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez
added kubernetes storage code
1fe8fce 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez
added etcd storage code
728a568 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez
migrate stmts
8b3712b 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez
migrate only for psql
dc21cd3 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez
migrate only for psql
11ddfe4 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez
migration fix
fc31c46 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez iamazzeez added the enhancement New feature or request label Mar 30, 2022
@iamazzeez iamazzeez requested review from kalroy and Dmaddu March 30, 2022 07:04
@iamazzeez iamazzeez self-assigned this Mar 30, 2022
@iamazzeez
test
5066d37 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez
test
1743e3e 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez
check if user is blocked logic
8fa56ff 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez
migration syntax fix
1cdf876 
Signed-off-by: Abdul-Az <[email protected]>
@Dmaddu Dmaddu marked this pull request as draft March 30, 2022 10:37
iamazzeez added 10 commits March 30, 2022 17:19
@iamazzeez
wip blocked user logic
69efe69 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez
update counter syntax fix
9eba331 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez
added ui render logic
21a88e4 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez
added ui render logic fix
720100b 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez
check if user is blocked condition
d10e5b5 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez
check if user is blocked condition fix
b1da635 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez
check if user is blocked condition fix
ce0950f 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez
check if user is blocked condition fix
34cf44e 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez
delete user on successful login
b68997b 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez
delete user on successful login fix
8a9bca6 
Signed-off-by: Abdul-Az <[email protected]>
Dmaddu
Dmaddu requested changes Apr 6, 2022
View reviewed changes
Copy link
Collaborator

@Dmaddu Dmaddu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please re-look into the code in terms of a maintenance perspective. Add more comments and use proper terminology to understand the code better.

@iamazzeez iamazzeez requested a review from Dmaddu April 11, 2022 10:25
@iamazzeez iamazzeez force-pushed the add_invalid_attempts branch from 6d784e6 to 5131d99 Compare April 12, 2022 08:37
@iamazzeez iamazzeez force-pushed the add_invalid_attempts branch from 5131d99 to b44b303 Compare April 12, 2022 08:39
@iamazzeez
sql row name update
fbc74d2 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez
debug stmts
bc65a45 
Signed-off-by: Abdul-Az <[email protected]>
Dmaddu
Dmaddu requested changes Apr 13, 2022
View reviewed changes
kalroy
kalroy reviewed Apr 14, 2022
View reviewed changes
Copy link
Collaborator

@kalroy kalroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the scenario answered for the reset attempt

@iamazzeez
added logs
c94d07d 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez
removeed logs
55798a5 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez iamazzeez requested a review from Dmaddu April 14, 2022 10:18
iamazzeez and others added 12 commits April 25, 2022 14:41
@iamazzeez
ldap invalidattempts handle fix
b162f79 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez
handle duplicate entries in invalid_attempts table
258273b 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez
handleInvalidLoginAttempts update for ldap
5ceaece 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez
error fix
f6cd315 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez
error fix
83cd8b8 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez
changed blockedDuration to blockedDurationInMinutes
70d1856 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez
reverted if not exists from create table
f5f1c79 
Signed-off-by: Abdul-Az <[email protected]>
@Dmaddu
Merge pull request #53 from chef/ldap_fix
b8e1a0b 
Fixed errors occurred while testing
@iamazzeez
updated_at time
aacac1d 
Signed-off-by: Abdul-Az <[email protected]>
@iamazzeez
updatedat fix
b5b1255 
Signed-off-by: Abdul-Az <[email protected]>
@Dmaddu
Merge pull request #56 from chef/ldap_fix
492576f 
Ldap fix
@SanjuPal01
Sanju/test refresh (#81)
6c1614c 
* Testing Refresh API

Signed-off-by: SanjuPal01 <[email protected]>

* Change 2

* Handler

* Last Used

* test

* Time Difference

* Check

* Token Validator

Signed-off-by: SanjuPal01 <[email protected]>

* Checking

* Check

* Test

* Test

* Check

* Check

* Check

* Check

* Check

* Check

* Check

* Check

* Check

* Check

* Check

* Removing Redundant Code

Signed-off-by: SanjuPal01 <[email protected]>

* Token Validator

Signed-off-by: SanjuPal01 <[email protected]>

* Removing Redundant Code

Signed-off-by: SanjuPal01 <[email protected]>

* Code Updated

Signed-off-by: SanjuPal01 <[email protected]>

* Fixed validator

Signed-off-by: SanjuPal01 <[email protected]>

* naming convention

Signed-off-by: SanjuPal01 <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 22 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@iamazzeez
pq pkg upgrade (#151)
ef6613f 
Signed-off-by: Abdul-Az <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 22 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalroy kalroy kalroy approved these changes

@Dmaddu Dmaddu Awaiting requested review from Dmaddu

Assignees

@iamazzeez iamazzeez

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iamazzeez @kalroy @Dmaddu @SanjuPal01