Skip to content
This repository has been archived by the owner on Feb 23, 2022. It is now read-only.

roger - no ticket - create statusWrapper component #449

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

roggc
Copy link
Contributor

@roggc roggc commented Feb 1, 2022

img1

Copy link
Member

@ralph-dev ralph-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roggc Doesn't this component already exist?

@roggc
Copy link
Contributor Author

roggc commented Feb 1, 2022

@roggc Doesn't this component already exist?

yes. the thing is I add a property named 'separation' to add space (margin) between the status dot and the text. the second is also the color of the text to be different than the color of the dot.

@ralph-dev
Copy link
Member

@roggc Doesn't this component already exist?

yes. the thing is I add a property named 'separation' to add space (margin) between the status dot and the text. the second is also the color of the text to be different than the color of the dot.

Ok I feel like you could have just extended properties on the existing component though. Also use the CE Repo not this Repo anymore

@roggc
Copy link
Contributor Author

roggc commented Feb 1, 2022

@roggc Doesn't this component already exist?

yes. the thing is I add a property named 'separation' to add space (margin) between the status dot and the text. the second is also the color of the text to be different than the color of the dot.

Ok I feel like you could have just extended properties on the existing component though. Also use the CE Repo not this Repo anymore

sorry, which is the CE Repo?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants