Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] account_financial_report: Migration to 18.0 #1

Merged
merged 313 commits into from
Dec 7, 2024

Conversation

chaule97
Copy link
Owner

@chaule97 chaule97 commented Nov 18, 2024

@chaule97 chaule97 force-pushed the 18.0-mig-account_financial_report branch 6 times, most recently from a026da4 to 995452d Compare November 19, 2024 03:17

def _get_report_name(self, report, data=False):
company_id = data.get("company_id", False)
report_name = _("Aged Partner Balance")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you forgot to replace it with self.env._ for the files in the report folder

@chaule97 chaule97 force-pushed the 18.0-mig-account_financial_report branch 2 times, most recently from 8b779ca to 4aca9bf Compare November 21, 2024 09:46
@chaule97 chaule97 requested a review from natuan9 November 21, 2024 09:50
@sebalix
Copy link

sebalix commented Nov 21, 2024

@chaule97 date_range and report_xlsx deps have been merged into 18.0

@chaule97 chaule97 force-pushed the 18.0-mig-account_financial_report branch 3 times, most recently from ff0b491 to 8f9d339 Compare November 25, 2024 07:38
eduaparicio and others added 15 commits November 29, 2024 15:38
Currently translated at 100.0% (329 of 329 strings)

Translation: account-financial-reporting-12.0/account-financial-reporting-12.0-account_financial_report
Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-12-0/account-financial-reporting-12-0-account_financial_report/pt_BR/
The number of computed account can be greater in certain databases with l10n modules.
Currently translated at 10.3% (34 of 329 strings)

Translation: account-financial-reporting-12.0/account-financial-reporting-12.0-account_financial_report
Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-12-0/account-financial-reporting-12-0-account_financial_report/fr/
Currently translated at 100.0% (329 of 329 strings)

Translation: account-financial-reporting-12.0/account-financial-reporting-12.0-account_financial_report
Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-12-0/account-financial-reporting-12-0-account_financial_report/pt_BR/
Currently translated at 23.1% (76 of 329 strings)

Translation: account-financial-reporting-12.0/account-financial-reporting-12.0-account_financial_report
Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-12-0/account-financial-reporting-12-0-account_financial_report/fr/
Currently translated at 23.1% (76 of 329 strings)

Translation: account-financial-reporting-12.0/account-financial-reporting-12.0-account_financial_report
Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-12-0/account-financial-reporting-12-0-account_financial_report/fr/
…cade

`report_journal_ledger` is auto-vacuumed as any transient model, but has some
ondelete="cascade" constraints that auto-remove subtables when a record is removed,
doing this operation very slow when selecting these sub-records.

Letting default ondelete="set null" would result in same performance bottleneck,
as the select on sub-table is performed the same for setting "null" value on them.

As a solution, and for avoiding a costly index operation, we delete by SQL sub-tables
rows in advance.

A bit of extra logic has been added for avoiding to remove that records if it's not
the turn of vacuum the parent table.
Currently translated at 84.5% (278 of 329 strings)

Translation: account-financial-reporting-12.0/account-financial-reporting-12.0-account_financial_report
Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-12-0/account-financial-reporting-12-0-account_financial_report/fr/
mymage and others added 19 commits November 29, 2024 15:38
Currently translated at 100.0% (267 of 267 strings)

Translation: account-financial-reporting-17.0/account-financial-reporting-17.0-account_financial_report
Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-17-0/account-financial-reporting-17-0-account_financial_report/it/
``analytic_distribution`` is a JSON field where keys are 'account.id' or 'account.id,account.id'
Eg: https://github.com/odoo/odoo/blob/8479b4e/addons/sale/models/account_move_line.py#L158
Previous implementation tried to convert to ``int`` the ``analytic_distribution`` dict keys, leading to a ``ValueError``.
This commit fixes this bug.
…umul cur. values in general ledger only if necessary

The currency_id field of the lines is always set, so follow the same logic as
in report/templates/general_ledger and show the data only if the currency is set
in the account.

TT51204
Currently translated at 100.0% (267 of 267 strings)

Translation: account-financial-reporting-17.0/account-financial-reporting-17.0-account_financial_report
Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-17-0/account-financial-reporting-17-0-account_financial_report/it/
…alance (just like we display null initial balance)
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-financial-reporting-17.0/account-financial-reporting-17.0-account_financial_report
Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-17-0/account-financial-reporting-17-0-account_financial_report/
…als if the account has not set currency

Related to OCA#1235 (comment)

[FIX] account_financial_report: Avoid error in General ledger if the Show foreign currency checkbox is not checked.

Related to OCA#1236

TT51996
@chaule97 chaule97 force-pushed the 18.0-mig-account_financial_report branch 2 times, most recently from f403480 to 8cd27bd Compare December 2, 2024 03:47
@chaule97 chaule97 force-pushed the 18.0-mig-account_financial_report branch 2 times, most recently from e439180 to 591eec6 Compare December 4, 2024 03:29
@chaule97 chaule97 force-pushed the 18.0-mig-account_financial_report branch from 591eec6 to 01f22b8 Compare December 4, 2024 07:41
@chaule97 chaule97 merged commit 470c4f3 into 18.0 Dec 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.