ability to setup and configure RotatingFileHandler for file logging #50
Conversation
* 'master' of https://github.com/grimoirelab/mordred: (60 commits) [release] Update version number to 0.1.12 [panels] Use the new kidash module, instead of grimoire-kidash [task_collection][arthur] Limit the total number of items collected from redis [task_collection][arthur] Set to 200MB the max memory for the arthur python dict [arthur] Limit the max size of the python memory with raw items from redis [tasks_panels] Add support for data sources when uploading panels. [docker] Use the new grimoirelab github repository location to download the releases [release] Update version number to 0.1.11 Fix grimoire_elk symbolic link changed by error [task_collection] Configure bulk and scroll size in arthur collection [tests] Fix tests to work with the new projects loading logic [tasks_project] Load projects in the initial tasks in mordred [task_collection] Create task in arthur only the first time [task_enrich] Minor fix in logs [task_identities] Add support for '--no-email-validation' option in grimoirelab2sh [release] Update version number to 0.1.10 [mordred] Use arthur upstream and not acs fork [task_collection][arthur] Compute the memory usage in intervals [docker] arthur is not used with Elasticsearch anymore [task_identities] Refactor code to address review comments by @albertinisg ...
…o False even though there might be an exception
|
@trbs I am going to review all this work asap. I am a bit overloaded past weeks. Thank you very much for your work. I promise I will invest time in reviewing it! Logs rotating is a critical feature for us in production, and any improvement will help! |
|
@acs great. Right now the PR is polluted with other fixes like the last commit resetting IDENTITIES_TASKS_ON when an error happens in sortinghat. For me that was mysql network error, which causes Mordred to "deadlock". (although i'm not sure if the driver recovers from it since I never use MySQL) Anyways please see which changes you want to merge and I can create new clean PR's for them. |
|
@trbs it is better to go step by step in the PRs. Each feature in a specific PR which can be merged without issues with master. Could you clean the PR so it merges with merges and it is only related to a specific feature? For example, the rotating of logs. The other features must be in new PRs. Thanks @trbs ! |
Add the ability to setup and configure rotating log files via RotatingFileHandler.
If wanted this patch could be extended for supporting other file handlers as well.
Or possibly disabling file handlers and only logging to console (which might be good for some container setups)