Fix various issues found by valgrind #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: In genders_handle_create() it manually cleans up on its error path. Call genders_handle_destroy() instead.
Problem: The list_append() wrapper returns GENDERS_ERR_INTERNAL on error. It should return a memory allocation error. Return GENDERS_ERR_OUTMEM instead.
Problem: The comment header to _insert_attr() is not accurate. Update the comment header accordingly.
Problem: A len parameter in _genders_open_and_parse() is not initialized unless the file is > 0 in length. It leads to valgrind warnings. Initialize the len to 0.
Problem: Several temp hostlists are not destroyed during genders query calculation. Destroy those temporary hostlists.
Problem: In some tests lists (i.e. nodelist, attrlist) is not cleared before a new test. So lingering data could sit from a prior test. Clear the lists before retesting.
Problem: Valgrind reports an initialization warning in the testsuite. Fix it and a related assert.
Problem: When testing genders_copy() the copy of the genders handle was not destroyed at test completion. Destroy the finished copy at test completion.
Problem: Valgrind reports memleaks on list creation tests. Fix up the list creation leaks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.