Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(design-tokens): fixed font family #921

Merged
merged 2 commits into from
Jan 9, 2025
Merged

fix(design-tokens): fixed font family #921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5073191
fix(design-tokens): fixed font family
masoudmanson Jan 8, 2025
ee1fb9a
docs(design-tokens): adding a comment about font-family
masoudmanson Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/components/src/common/styles-dictionary/config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,16 @@
/* Font-family explanation:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks perfect! Thanks for taking the time to do it 🤩 🏆 🙏

The following font stack is designed to provide compatibility across multiple operating systems:
- var(--font-inter): Custom Inter font defined by Next.js.
- Inter: Standard Inter font fallback.
- -apple-system, BlinkMacSystemFont: macOS-specific system fonts.
- Segoe UI: Default system font for Windows.
- Roboto: Default system font for most Linux distributions.
- Helvetica Neue, Helvetica, Arial, sans-serif: General fallbacks to ensure compatibility.
Reference:
An article explaining how platforms like GitHub and Medium use similar fallback font stacks.
Link: https://css-tricks.com/snippets/css/system-font-stack/
*/

const config = {
platforms: {
css: {
Expand Down
Loading
Loading