Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix validation errors in issue templates #730

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

jfoo1984
Copy link
Contributor

@jfoo1984 jfoo1984 commented Dec 1, 2023

Summary

Fix validation issues in issue template updates in #723. Because of these validation errors, the new issue template forms are not showing up when trying to create a new issue.

Screenshots

Before
image
image

After
image
image

Checklist

  • Default Story in Storybook
  • LivePreview Story in Storybook
  • Test Story in Storybook
  • Tests written
  • Variables from defaultTheme.ts used wherever possible
  • If updating an existing component, depreciate flag has been used where necessary
  • Chromatic build verified by @chanzuckerberg/sds-design

Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hurray! Thanks so much for checking and fixing this, @jfoo1984 🙏 !! LGTM!

@tihuan tihuan merged commit e01999e into main Dec 1, 2023
9 checks passed
@tihuan tihuan deleted the fix-issue-template-errors branch December 1, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants