Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icon): add cube icon #725

Merged
merged 2 commits into from
Dec 6, 2023
Merged

feat(icon): add cube icon #725

merged 2 commits into from
Dec 6, 2023

Conversation

liaprins
Copy link
Contributor

@liaprins liaprins commented Nov 29, 2023

Add new Cube icon in sizes L and XL

re #720

Summary

Icon
Github issue: #720
Add new Cube icon

Pre-hover and hover in warning color:
Screenshot 2023-11-29 at 3 52 25 PM
Screenshot 2023-11-29 at 3 52 30 PM

NOTE: I am also having David Ruiz help to review PRs for SDS Hackday.

Checklist

  • Default Story in Storybook
  • LivePreview Story in Storybook
  • Test Story in Storybook
  • Tests written
  • Variables from defaultTheme.ts used wherever possible
  • If updating an existing component, depreciate flag has been used where necessary
  • Chromatic build verified by @chanzuckerberg/sds-design

Add new Cube icon in sizes L and XL

re #720
Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hurray! Thanks so much for adding this, Lia! You so productive 🔥

@DRuizCZI
Copy link

LGTM

Copy link

@clarsen-czi clarsen-czi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @liaprins !!

Copy link
Contributor

@masoudmanson masoudmanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @liaprins! LGTM 🤩 Thank you for your contributions!

@masoudmanson masoudmanson added the Ready for release This PR is ready for release label Dec 5, 2023
@masoudmanson masoudmanson merged commit a534985 into main Dec 6, 2023
7 checks passed
@masoudmanson masoudmanson deleted the cube-icon branch December 6, 2023 00:52
@masoudmanson masoudmanson added Released and removed Ready for release This PR is ready for release labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants