feat: Add gha for merging prod into main #715
Conversation
There was a problem hiding this comment.
Hurray! Thanks so much for closing the manual loop in the deploy process for us, @alldoami 🤩 👏
Really appreciate the context shared in the PR description too. Super helpful and lots of TILs 💡
Will wait for @masoudmanson to LGTM, in case I missed anything lol
Thanks again!!
|
|
||
| # Step 14: Autoapprove PR | ||
| # Step 15: Autoapprove PR |
There was a problem hiding this comment.
Brilliant 🔥 !!! Thanks so much for auto merging the PR 🚀 💡 This is SO exciting!!
There was a problem hiding this comment.
Incredible work, @alldoami! Thank you for your dedication and effort in putting this together. it's truly remarkable! 😍🥳🤩
There was a problem hiding this comment.
Thank you, @alldoami, for your contribution. This means a lot to us! 😍 I'm going to go ahead and merge this PR and start using the new workflows. 🥳
|
|
||
| # Step 14: Autoapprove PR | ||
| # Step 15: Autoapprove PR |
There was a problem hiding this comment.
Incredible work, @alldoami! Thank you for your dedication and effort in putting this together. it's truly remarkable! 😍🥳🤩
| private_key: ${{ secrets.CZI_GITHUB_HELPER_PK }} | ||
|
|
||
| # Step 15: Autoapprove PR | ||
| - name: Autoapprove PR |
There was a problem hiding this comment.
Oh 😯
I had no idea we could auto-approve the PRs ⭐️
This is fantastic! Thanks for sharing 🥳
masoudmanson
added
Released
and removed
Ready for release
Summary
Step in release action to create a PR after release steps are done. I caught up with Masoud and he said this is the only manual step that is still happening in the release process.
Here is some fun documentation on the
GITHUB_TOKENsecret that I learned: https://docs.github.com/en/actions/security-guides/automatic-token-authentication#about-the-github_token-secretHere is documentation about the create pr gha: https://github.com/marketplace/actions/create-pull-request
Added the ability to autoapprove and automerge the PR. Docs: https://github.com/marketplace/actions/enable-pull-request-automerge.
Did thorough testing here: https://github.com/chanzuckerberg/ghas-internal-feature-testing/pull/7. Thanks to @hspitzley-czi for helping me out with this!
Feedback I'd like:
Is this the right place to put this? Should this step go at the very bottom of this file after job 3? I put it at the end of Job 1 because if all of those steps succeed, then this should be run, correct?
Checklist
defaultTheme.tsused wherever possible