Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multicolumnautocomplete): first implementation #670

Merged
merged 17 commits into from
Nov 22, 2023
Merged

feat(multicolumnautocomplete): first implementation #670

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
f920cfd
feat(multicolumnautocomplete): first implementation
masoudmanson Oct 31, 2023
a7b99a3
fix(multicolumnautocomplete): add border right
masoudmanson Oct 31, 2023
ce37efa
fix(autocomplete): fix test and linter errors
masoudmanson Nov 1, 2023
a1591bd
feat(dropdown): add MultiColumn feature to DropdownMenu, Dropdown and…
masoudmanson Nov 14, 2023
3b7ed6f
fix(autocomplete): fix autcomplete demo
masoudmanson Nov 14, 2023
153bf2e
refactor(autocomplete): remove AutocompleteBase and AutocompleteMulti…
masoudmanson Nov 14, 2023
1c43282
refactor(autocomplete): replace all DefaultDropdownMenuOptions with D…
masoudmanson Nov 14, 2023
f691ab1
fix(autocomplete): fix typos and move AutocompleteBase, AutocompleteM…
masoudmanson Nov 15, 2023
d31479d
fix(autocomplete): fix scroll reset bug and design review styles
masoudmanson Nov 17, 2023
f7644d1
fix(dropdownmenu): fix cognetive complexity error
masoudmanson Nov 17, 2023
0a2a9fe
feat(autocomplete): add custom PopperComponent for Autocomplete, Auto…
masoudmanson Nov 20, 2023
69522e7
fix(storybook): upgrade to the latest version
masoudmanson Nov 20, 2023
413bc5e
refactor(sutocomplete): fix styles and code clean up
masoudmanson Nov 22, 2023
4824f9a
refactor(autocomplete): use MUI class names object
masoudmanson Nov 22, 2023
4b14396
fix(autocomplete): remove dead code
masoudmanson Nov 22, 2023
6e61b63
Merge branch 'main' of https://github.com/chanzuckerberg/sci-componen…
masoudmanson Nov 22, 2023
d6fc82b
refactor(autocomplete): update comments and code cleanup
masoudmanson Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .storybook/manager-head.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
<link
href="https://fonts.googleapis.com/css2?family=Open+Sans:ital,wght@0,300;0,400;0,600;0,700;0,800;1,400;1,600;1,700&display=swap"
rel="stylesheet"
crossorigin="anonymous"
/>
<title>SDS Design System</title>
<style>
Expand Down
1 change: 1 addition & 0 deletions .storybook/preview-head.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@
<link
href="https://fonts.googleapis.com/css2?family=Open+Sans:ital,wght@0,300;0,400;0,600;0,700;0,800;1,400;1,600;1,700&display=swap"
rel="stylesheet"
crossorigin="anonymous"
/>
9 changes: 7 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,10 @@
"typescript": "^5.1.3",
"url-loader": "^4.1.1"
},
"resolutions": {
"@types/react": "17.0.2",
"@types/react-dom": "17.0.1"
},
"scripts": {
"start": "storybook dev -p 6006",
"build-storybook": "storybook build -o docs-build",
Expand All @@ -118,7 +122,7 @@
"lint": "lerna run lint",
"build": "lerna run build",
"ci": "yarn install --immutable",
"version:ci":"HUSKY=0 lerna version --yes --conventional-commits",
"version:ci": "HUSKY=0 lerna version --yes --conventional-commits",
"publish:ci": "HUSKY=0 lerna publish from-package --yes"
},
"lint-staged": {
Expand Down Expand Up @@ -150,5 +154,6 @@
"workspaces": [
"packages/*"
],
"main": "index.js"
"main": "index.js",
"dependencies": {}
}
2 changes: 2 additions & 0 deletions packages/components/src/common/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,5 @@ export const noop = (): void => {};

export const toKebabCase = (str: string) =>
str.replace(/[\s_]+/g, "-").toLowerCase();

export const EMPTY_OBJECT = {};
masoudmanson marked this conversation as resolved.
Show resolved Hide resolved
7 changes: 1 addition & 6 deletions packages/components/src/core/Autocomplete/Autocomplete.namespace-test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,7 @@ const OPTIONS = [
];

const AutocompleteNameSpaceTest = (
props: AutocompleteProps<
DefaultAutocompleteOption,
true,
undefined,
undefined
>
props: AutocompleteProps<DefaultAutocompleteOption, true, false, false>
) => {
return (
<Autocomplete
Expand Down
5 changes: 1 addition & 4 deletions packages/components/src/core/Autocomplete/__snapshots__/index.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ exports[`<Autocomplete /> Default story renders snapshot 1`] = `
style="margin: 16px 0px 0px 24px; width: 300px;"
>
<div
class="MuiAutocomplete-root MuiAutocomplete-hasPopupIcon css-t46og2-MuiAutocomplete-root"
class="MuiAutocomplete-root MuiAutocomplete-hasPopupIcon css-1o14u71-MuiAutocomplete-root"
label="Search by label"
>
<div
Expand Down Expand Up @@ -84,8 +84,5 @@ exports[`<Autocomplete /> Default story renders snapshot 1`] = `
</div>
</div>
</div>
<div
style="margin-top: 10px;"
/>
</div>
`;
Loading