Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Finish migrating deposition and datasets aggregates to use V2 #1512

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bchu1
Copy link
Contributor

@bchu1 bchu1 commented Jan 24, 2025

#1228 #1230

  • Switches all relevant code to use new V2 DatasetsAggregates fragment.
  • Removes some fields from the main deposition query that were already covered by the fragment.
  • Fix bug where total dataset count was querying for datasets with the deposition ID rather than datasets with annotations with the deposition ID.
  • This temporarily puts the data in the deposition page in an inconsistent state when using annotation filters, because the table is still using V1 whose query is technically wrong (it allows datasets that have annotations belonging to the deposition and any other annotation matching the annotation filter, rather than datasets that have annotations that both belong to the dataset and the annotation filter).

Copy link
Contributor

Frontend Preview URL

https://bchu-actualdatasets.cryoet.dev.si.czi.technology

Updated: 01/24/25 @ 09:35:32 AM PST

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant