fix: Fix hydration errors throughout app #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchu1
changed the title
rainandbare
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve https://czi-sci.slack.com/archives/C05S98P75NW/p1737656647158829 which seems to be caused by some Remix bug (?) where sometimes the page doesn't get overwritten with the hydrated DOM (which was different due to these hydration errors).
<Paper>wrapper in tooltip (it was getting positionally shifted by the other fixes for some reason, but it should've been removed anyways as the recent SDS update made extra<Paper>redundant (and ugly)).<div>s being under<p>s.<p>s being under<tr>s.