Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Migrate datasets and deposition filter values to use V2 data #1502

Merged
merged 2 commits into from
Jan 23, 2025
Merged

feat: Migrate datasets and deposition filter values to use V2 data #1502

merged 2 commits into from
Jan 23, 2025

Conversation

bchu1
Copy link
Contributor

@bchu1 bchu1 commented Jan 23, 2025 •
edited
Loading

@bchu1 bchu1 requested review from kne42 and rainandbare January 23, 2025 01:05
@bchu1 bchu1 marked this pull request as ready for review January 23, 2025 01:05
@bchu1 bchu1 changed the title feat: Migrate filter values to use V2 feat: Migrate filter values to use V2 data Jan 23, 2025
@bchu1 bchu1 changed the title feat: Migrate filter values to use V2 data feat: Migrate datasets and deposition filter values to use V2 data Jan 23, 2025
rainandbare
rainandbare approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@rainandbare rainandbare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@rainandbare
Copy link
Contributor

So what's up with this "annotationCount": 35769, in the frontend tests?

@bchu1
Copy link
Contributor Author

bchu1 commented Jan 23, 2025

So what's up with this "annotationCount": 35769, in the frontend tests?

No idea 😞 I asked on Slack and no one responded 😢 https://czi-sci.slack.com/archives/C07DNE66ZS9/p1736965901947069

@bchu1 bchu1 merged commit f338feb into main Jan 23, 2025
17 of 18 checks passed
@bchu1 bchu1 deleted the bchu/datasetsagg branch January 23, 2025 17:24
@github-actions github-actions bot mentioned this pull request Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainandbare rainandbare rainandbare approved these changes

@kne42 kne42 Awaiting requested review from kne42

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bchu1 @rainandbare