fix: More adjustments to run query differ #1501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainandbare
approved these changes
Jan 23, 2025
Comment on lines
+365
to
+367
| .sort((authorA, authorB) => | ||
| authorA.node.name.localeCompare(authorB.node.name), | ||
| ), |
There was a problem hiding this comment.
We are sorting it in two places to compare v1 to v2?
There was a problem hiding this comment.
Exactly, so for fields where both V1 and V2 have non-deterministic ordering, we have to sort both of them (sometimes when it makes sense from the user's perspective I'll just add sorting to the GQL query, but for this one it'll prolly just make things more confusing if I do that bc we're sorting it again in the <AuthorList> component)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1232