feat: Update ML Challenge banner #1457

bchu1 · 2025-01-10T18:16:01Z

This should be merged right before 1/15.

Makes some code simplifications:

Removes timer logic. We can just make the changes manually before the dates when the banner needs to be updated. This is so we have more testability and control over the code. Product also did not request any countdown text in the final copy.
Removes usage of poorly documented third party hook, just uses localStorage directly.
Switches from using 1 localStorage key to keep track of the last dismissed banner version to using separate keys for each banner version.

* main: (25 commits) feat: Diff logging for deposition page (#1467) chore(main): release web 1.43.0 (#1474) feat: Another dummy PR (#1473) chore(main): release web 1.42.0 (#1472) feat: Dummy PR to trigger release please (#1471) chore(main): release web 1.41.0 (#1461) feat: Update ML Challenge banner (#1457) feat: Convert deposition page query to V2 (#1452) fix: Fix deposition filter on run page (#1466) docs: Add anchors to FAQ questions (#1458) chore: Refactor datasets filter values fragment (#1456) feat: Add plausible analytics tracking to pages (#1459) chore(main): release web 1.40.0 (#1441) feat: Add diff detection for new datasets page query (#1446) fix: Remove non-null assertions in dataset page hook (#1450) fix: Never send empty argument objects to APIv2 (#1447) fix: Fix deposition dropdown filters being broken (#1448) feat: Migrate datasets page query (#1438) test: filter components unit tests (#1436) chore(main): release web 1.39.0 (#1437) ...

b943866

bchu1 temporarily deployed to local January 10, 2025 18:16 — with GitHub Actions Inactive

bchu1 added the preview label Jan 10, 2025

bchu1 temporarily deployed to dev January 10, 2025 18:16 — with GitHub Actions Inactive

bchu1 had a problem deploying to local January 10, 2025 18:20 — with GitHub Actions Error

bchu1 had a problem deploying to local January 10, 2025 18:20 — with GitHub Actions Failure

bchu1 had a problem deploying to local January 10, 2025 18:20 — with GitHub Actions Error

bchu1 temporarily deployed to local January 10, 2025 18:20 — with GitHub Actions Inactive

d092b3e

bchu1 temporarily deployed to dev January 10, 2025 18:27 — with GitHub Actions Inactive

bchu1 temporarily deployed to local January 10, 2025 18:27 — with GitHub Actions Inactive

bchu1 had a problem deploying to local January 10, 2025 18:31 — with GitHub Actions Error

bchu1 temporarily deployed to local January 10, 2025 18:31 — with GitHub Actions Inactive

bchu1 had a problem deploying to local January 10, 2025 18:31 — with GitHub Actions Failure

bchu1 temporarily deployed to local January 10, 2025 18:31 — with GitHub Actions Inactive

5be3f5e

bchu1 temporarily deployed to dev January 10, 2025 18:40 — with GitHub Actions Inactive

bchu1 temporarily deployed to local January 10, 2025 18:40 — with GitHub Actions Inactive

bchu1 had a problem deploying to local January 10, 2025 18:45 — with GitHub Actions Error

bchu1 had a problem deploying to local January 10, 2025 18:45 — with GitHub Actions Failure

bchu1 had a problem deploying to local January 10, 2025 18:45 — with GitHub Actions Error

35f4429

bchu1 temporarily deployed to dev January 10, 2025 18:58 — with GitHub Actions Inactive

bchu1 temporarily deployed to local January 10, 2025 18:58 — with GitHub Actions Inactive

bchu1 changed the title ~~feat: Update ML Challenge banner~~ Update ML Challenge banner Jan 10, 2025

bchu1 had a problem deploying to local January 10, 2025 19:03 — with GitHub Actions Error

bchu1 had a problem deploying to local January 10, 2025 19:53 — with GitHub Actions Error

bchu1 temporarily deployed to local January 10, 2025 19:53 — with GitHub Actions Inactive

relaly

a523be2

bchu1 temporarily deployed to dev January 10, 2025 19:57 — with GitHub Actions Inactive

bchu1 temporarily deployed to local January 10, 2025 19:57 — with GitHub Actions Inactive

bchu1 had a problem deploying to local January 10, 2025 20:01 — with GitHub Actions Error

0ad4c1d

bchu1 temporarily deployed to dev January 10, 2025 20:02 — with GitHub Actions Inactive

bchu1 temporarily deployed to local January 10, 2025 20:02 — with GitHub Actions Inactive

bchu1 temporarily deployed to local January 10, 2025 20:06 — with GitHub Actions Inactive

bchu1 had a problem deploying to local January 10, 2025 20:06 — with GitHub Actions Failure

bchu1 had a problem deploying to local January 10, 2025 20:06 — with GitHub Actions Error

bchu1 requested review from tihuan and junxini January 10, 2025 20:37

bchu1 marked this pull request as ready for review January 10, 2025 20:37

bchu1 requested a review from ehoops-cz January 13, 2025 18:25

ehoops-cz approved these changes Jan 13, 2025

View reviewed changes

bchu1 changed the title ~~Update ML Challenge banner~~ feat: Update ML Challenge banner Jan 14, 2025

bchu1 merged commit d873866 into main Jan 14, 2025
11 of 19 checks passed

bchu1 deleted the bchu/banner branch January 14, 2025 21:29

bchu1 had a problem deploying to dev January 14, 2025 21:29 — with GitHub Actions Failure

github-actions bot mentioned this pull request Jan 14, 2025

chore(main): release web 1.41.0 #1461

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Update ML Challenge banner #1457

feat: Update ML Challenge banner #1457

bchu1 commented Jan 10, 2025 •

edited

Loading

feat: Update ML Challenge banner #1457

feat: Update ML Challenge banner #1457

Conversation

bchu1 commented Jan 10, 2025 • edited Loading

bchu1 commented Jan 10, 2025 •

edited

Loading