fix: Remove non-null assertions in dataset page hook #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehoops-cz
approved these changes
Jan 9, 2025
kne42
added a commit
that referenced
this pull request
Jan 17, 2025
* main: (25 commits) feat: Diff logging for deposition page (#1467) chore(main): release web 1.43.0 (#1474) feat: Another dummy PR (#1473) chore(main): release web 1.42.0 (#1472) feat: Dummy PR to trigger release please (#1471) chore(main): release web 1.41.0 (#1461) feat: Update ML Challenge banner (#1457) feat: Convert deposition page query to V2 (#1452) fix: Fix deposition filter on run page (#1466) docs: Add anchors to FAQ questions (#1458) chore: Refactor datasets filter values fragment (#1456) feat: Add plausible analytics tracking to pages (#1459) chore(main): release web 1.40.0 (#1441) feat: Add diff detection for new datasets page query (#1446) fix: Remove non-null assertions in dataset page hook (#1450) fix: Never send empty argument objects to APIv2 (#1447) fix: Fix deposition dropdown filters being broken (#1448) feat: Migrate datasets page query (#1438) test: filter components unit tests (#1436) chore(main): release web 1.39.0 (#1437) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I found out sometimes the
aggregatearray is actually empty in Platformics, I realized it's probably better to just not make any non-null assumptions about Platformics responses anymore.