Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add diff detection for new datasets page query #1446

Merged
merged 5 commits into from
Jan 9, 2025
Merged

feat: Add diff detection for new datasets page query #1446

merged 5 commits into from
Jan 9, 2025

Conversation

bchu1
Copy link
Contributor

@bchu1 bchu1 commented Jan 7, 2025

This produces a log when the V1 and V2 API responses diverge.

Also:

  • Make the sorting of datasets a bit more deterministic (sort by title after sorting by release date).
  • Remove non-null assertions that were assuming that all groupBy keys are defined (forgot that null is a valid groupBy value for optional fields).

@bchu1 bchu1 requested review from tihuan and ehoops-cz January 8, 2025 23:35
@bchu1 bchu1 marked this pull request as ready for review January 8, 2025 23:35
@bchu1 bchu1 merged commit 2ac96b6 into main Jan 9, 2025
16 checks passed
@bchu1 bchu1 deleted the bchu/diff branch January 9, 2025 17:15
kne42 added a commit that referenced this pull request Jan 17, 2025
* main: (25 commits)
  feat: Diff logging for deposition page (#1467)
  chore(main): release web 1.43.0 (#1474)
  feat: Another dummy PR (#1473)
  chore(main): release web 1.42.0 (#1472)
  feat: Dummy PR to trigger release please (#1471)
  chore(main): release web 1.41.0 (#1461)
  feat: Update ML Challenge banner (#1457)
  feat: Convert deposition page query to V2 (#1452)
  fix: Fix deposition filter on run page (#1466)
  docs: Add anchors to FAQ questions (#1458)
  chore: Refactor datasets filter values fragment (#1456)
  feat: Add plausible analytics tracking to pages (#1459)
  chore(main): release web 1.40.0 (#1441)
  feat: Add diff detection for new datasets page query (#1446)
  fix: Remove non-null assertions in dataset page hook (#1450)
  fix: Never send empty argument objects to APIv2 (#1447)
  fix: Fix deposition dropdown filters being broken (#1448)
  feat: Migrate datasets page query (#1438)
  test: filter components unit tests (#1436)
  chore(main): release web 1.39.0 (#1437)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants